-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenSSL 3.x support needed for Fedora, CentOS, RHEL #276
Comments
If you're in a hurry and you want to reproduce the issue quickly from Fedora 36, just build this container using FROM registry.fedoraproject.org/fedora:rawhide
RUN dnf -y install cmake cython gcc-c++ findutils git make openssl-devel patch python3-devel python3-pip
RUN git clone https://github.com/Azure/azure-uamqp-python
# Apply a small patch to compile with GCC 11.x.
RUN curl -sL https://src.fedoraproject.org/rpms/python-uamqp/raw/rawhide/f/python-uamqp-1.2.14-gcc11.patch | patch -p0 -d azure-uamqp-python
# Don't treat warnings as errors.
RUN grep -rl "\-Werror" azure-uamqp-python/ | xargs sed -i 's/-Werror//'
RUN pip install --no-binary :all: azure-uamqp-python/ |
thanks for reaching out. openssl 3.0 is fairly new, we will take a look into it. |
Thanks, @yunhaoling! 🎉 |
hey @major , apologize for the late update. As you might know, uamqp is depending on a C library: https://github.com/Azure/azure-c-shared-utility and from what I learned it doesn't yet support OpenSSL3.0, discussion could be found here: Azure/azure-c-shared-utility#566. I feel sorry that currently there's nothing I could with the underlying C code except waiting for the C team to support it -- What I can do is that I'll leave a comment in the discussion adding a data point for the openssl 3.0 support, hope that could help to some extent :). May I ask whether you're using uamqp library alone to build application or you're using azure-eventhub, azure-servicebus instead? |
@yunhaoling Thanks for the reply! I'm packaging azure-cli on Fedora and this is one of the requirements within azure-cli or one of the Python SDKs. In the meantime, I can link to OpenSSL 1.1 and that works. |
Looking forward to openssl3 support |
Red Hat Enterprise Linux (RHEL) 9 made the move to OpenSSL 3.0 as well and I'm unable to package uamqp there, either. That affects CentOS Stream 9, Rocky, Alma, etc. Looks like there's a discussion underway here: Azure/azure-c-shared-utility#566 |
|
Hey,
|
Hey, any update on this? still a problem for uampq 1.6.3 on Linux Alpine |
A version bump would be useful so openSUSE is now affected as well as it recently switched to OpenSSL 3.0. |
Hi All, sorry for the delay in response. I'm working on a few changes to bring about openSSL 3.0 support and am planning to release in the next cycle based on internal testing etc. I was able to build the module successfully on Fedora rawhide using the following:
|
The same on Alpine 3.17 with python 3.10.10 |
Any news on if this is going to be merged in? |
Still running into the issue on Fedora + OpenSSL 3.x + uamqp 1.6.4 |
@major Ill be releasing a new version of uamqp next week. I think there was a missing piece to the equation. Can you try running against main please? The last time I tried on Fedora machine with those changes I was able to compile properly. |
@kashifkhan any thoughts on when this code will be published? I've been building from |
@ kashifkhan - just checking in to see what the plan is here, please |
@toddbu sorry for the delay. We plan on doing a release at the end of this month with the changes that are currently in main. |
@toddbu I have now released uamqp 1.6.5 which includes all the latest changes. |
Thanks @kashifkhan. I went to go test this today but it appears that one of my teammates removed our dependency on this module. Sorry :-( |
@toddbu no worries, just out of curiosity are you using uamqp directly or azure event hubs or service bus python libraries ? same question for @hgyn59 |
Describe the bug
Fedora 36 contains [OpenSSL 3|https://fedoraproject.org/wiki/Changes/OpenSSL3.0] and uamqp fails to compile with it. (Full error pasted below.)
To Reproduce
Steps to reproduce the behavior:
podman run --rm -it registry.fedoraproject.org/fedora:rawhide
dnf -y install cmake make gcc-c++ openssl-devel cython
pip -vvv install --no-binary :all: uamqp
Expected behavior
I expected the module to be built.
Additional context
The text was updated successfully, but these errors were encountered: