Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add ErrorTrigger #342

Open
brettsam opened this issue Dec 1, 2017 · 8 comments
Open

Re-add ErrorTrigger #342

brettsam opened this issue Dec 1, 2017 · 8 comments
Assignees
Labels
Milestone

Comments

@brettsam
Copy link
Member

brettsam commented Dec 1, 2017

ErrorTrigger was removed when we removed internal usage of TraceWriter as it was built on the TraceWriter. This issue tracks the re-adding of this to the .NET Core branch.

@mathewc
Copy link
Member

mathewc commented Dec 15, 2017

The feature is currently built on the TraceWriter event stream, so should be directly portable over to the ILogger event stream, since the whole infrastructure is simply sliding window monitoring over an event stream.

I still think it is is a logical design for this to be based on the log stream. While we might consider invention of a new message bus to base this on, I don't think we need to do that.

@paulbatum paulbatum added this to the Triaged milestone Dec 15, 2017
@paulbatum paulbatum modified the milestones: Triaged, Backlog Feb 21, 2018
@rholsman
Copy link

Is there any way we can get examples of this new pattern? I happened to start a new webjob project within a week of the release of SDK 3.0 and had lots of trouble finding documentation on the changes. I waited for updates to the wiki or microsoft documentation but still can only find the old documentation which no longer works. I have went through the sample code and unit tests on the git hub pages and I find it difficult to find tests or examples for many things such as logging, di in a webjob, activators, webjob hosting (this may be better now), and error handling. With large breaking changes to patterns, libraries, and application design with each major release it makes it very hard to keep on top of best practices. It doesn't feel like there is functional parity between versions; I am sure there is but its very difficult to find especially as functionalities are moved into different objects and namespaces.

@simongullberg
Copy link

Do you have any ETA on when the ErrorTriggerAttribute will be added to .NET Core?

@mathewc
Copy link
Member

mathewc commented May 15, 2019

No plans or ETA for this currently.

@OzBob
Copy link

OzBob commented Sep 11, 2019

Still in wiki: https://github.com/Azure/azure-webjobs-sdk-extensions/wiki/Error-Monitoring
and Readme references a code sample not in the repository.

@jonathanantoine
Copy link

Any update ? Error management is pretty useful in real world :)

@jimpaton-ufx
Copy link

Again, 18 months from the last comment, is there any progress on this? I just inherited a .NET 4.5.2 project that uses v1 of the WebJobs SDK and it's impossible to update in any meaningful way because it uses this feature and it's been removed with no replacement. If it's as simple as replacing every usage of TraceWriter with ILogger, why is the feature still missing after nearly 4 years and another major version release of the SDK?

@remde
Copy link

remde commented Apr 27, 2023

Hi -- 18 months after the last comment, is there any progress or alternative for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

9 participants