Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5.x release to support cleanly TimerTrigger with Azure Storage V12 #805

Open
superjulius opened this issue Oct 28, 2022 · 7 comments
Open
Assignees

Comments

@superjulius
Copy link

superjulius commented Oct 28, 2022

We have been upgrading our WebJobs to use Microsoft.Azure.WebJobs.Extensions.Storage 5.x successfully except for the ones that are using TimerTrigger.

TimerTrigger is only available in Microsoft.Azure.WebJobs.Extensions 4.0.1, which depends on Microsoft.Azure.WebJobs.Host.Storage using Azure Storage 11.x

TimerTrigger is also available in the Microsoft.Azure.WebJobs.Extensions 5.x beta.

Is there any plan to move out of beta for 5.x? If not any time soon, is that beta production ready/safe?

Expected behavior

  • No more reference to Microsoft.Azure.WebJobs.Extensions 4.0.1 referencing old Azure Storage SDK
  • Cleaner Startup code
builder.ConfigureWebJobs((context, b) =>
              {
                  b.AddAzureStorageQueues();
                  b.AddAzureStorageBlobs();
                  b.AddExecutionContextBinding();
                  b.AddTimersWithStorage();
              })

Actual behavior

  • Requires reference to to Microsoft.Azure.WebJobs.Extensions 4.0.1 referencing old Azure Storage SDK causing some confusion
  • Cluttered startup code
builder.ConfigureWebJobs((context, b) =>
              {
                  b.AddAzureStorageCoreServices();
                  b.AddAzureStorageQueues();
                  b.AddAzureStorageBlobs();
                  b.AddExecutionContextBinding();
                  b.AddTimers();
              })

Related information

#745 Adding storagev12 ScheduleMonitor implementation
cc @karshinlin

@ghost ghost added the Needs: Triage 🔍 label Oct 28, 2022
@ramya894 ramya894 assigned ramya894 and unassigned ramya894 Nov 2, 2022
@ramya894
Copy link

@karshinlin do you have any inputs here.

@ramya894 ramya894 self-assigned this Nov 14, 2022
@karshinlin
Copy link
Contributor

@karshinlin do you have any inputs here.

I have flagged this with our team. You will need to use the 5.x beta packages today for Timer Trigger to support the v12 storage SDKs. @mattchenderson for more input on the timeline for taking these packages out of GA

@ramya894
Copy link

Closing it as answered

@ghost ghost removed the Needs: Triage 🔍 label Dec 15, 2022
@superjulius
Copy link
Author

@ramya894 Question was indeed answered.

Would have been nice though to hear back from @mattchenderson on the timeline to have the package out of beta

@bhagyshricompany
Copy link

@superjulius will update you soon

@bhagyshricompany
Copy link

@mattchenderson pls commnets

@mattchenderson
Copy link

I don't have an exact ETA for this at the moment, but that's something I've been trying to get a bit more clarity on. It hopefully shouldn't be too far out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants