Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Event Hubs related exceptions captured by ProcessErrorAsync #1357

Closed
paulbatum opened this issue Sep 23, 2017 · 2 comments
Closed

Log Event Hubs related exceptions captured by ProcessErrorAsync #1357

paulbatum opened this issue Sep 23, 2017 · 2 comments
Assignees
Milestone

Comments

@paulbatum
Copy link
Member

This code appears to be silently throwing away errors that come from event processor host.

public Task ProcessErrorAsync(PartitionContext context, Exception error)
{
// TODO: log underlying event hubs error
return Task.CompletedTask;
}

We need to wire this code path up to both system logs and application logs.

@paulbatum
Copy link
Member Author

Ideally fix for both functions v1, v2

@pragnagopa
Copy link
Member

pragnagopa commented Feb 16, 2018

Will not be porting this fix to V1 as ProcessErrorAsync - helper method where we can log underlying errors is only available in V2 as it depends on Microsoft.Azure.EventHubs.Processor. V1 depends on Microsoft.Azure.ServiceBus which does not have an equivalent of ProcessErrorAsync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants