Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MSAL GO example to use long term supported SDK #622

Closed
jeffpuckett opened this issue Oct 31, 2022 · 3 comments
Closed

Update MSAL GO example to use long term supported SDK #622

jeffpuckett opened this issue Oct 31, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@jeffpuckett
Copy link

Describe the bug
The MSAL GO example uses autorest which is not supported after March 2023. Update the sample to something that will be supported long term.

Steps To Reproduce

Expected behavior
Example using library that will be supported long term.

Logs

Environment

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Network plugin and version (if this is a network-related bug):
  • Others:

Additional context

@jeffpuckett jeffpuckett added the bug Something isn't working label Oct 31, 2022
@aramase
Copy link
Member

aramase commented Oct 31, 2022

For long term, please refer to the azure identity examples: https://github.com/Azure/azure-workload-identity/tree/main/examples/azure-identity.

@aramase aramase closed this as completed Oct 31, 2022
@jeffpuckett
Copy link
Author

This is not complete. The link provided does not offer examples for GO.

@aramase
Copy link
Member

aramase commented Oct 31, 2022

This is not complete. The link provided does not offer examples for GO.

@jeffpuckett The GO sdk support is still in beta which is why we haven't published it yet. When v1.2.0 of azure identity is released, we'll add that example. The MSAL examples were added earlier because azure identity still didn't support client assertion. The SDK team recommendation is to use azure identity instead of MSAL. If you're interested in trying out the go example, this is what they have so far: Azure/azure-sdk-for-go#15615 (comment).

The intent was not to mark it completed but to say we'll update when the official release is available. For now there is no official release for the azidentity go SDK yet. Here is an issue to track adding that: #187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants