Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Was alpha rolled out to aks ? #751

Closed
thomasfrederikhoeck opened this issue Feb 10, 2023 · 7 comments
Closed

Was alpha rolled out to aks ? #751

thomasfrederikhoeck opened this issue Feb 10, 2023 · 7 comments
Labels

Comments

@thomasfrederikhoeck
Copy link

Describe the bug
At the same time as v1.0.0-alpha.0 was released my pods starting failing with azure.identity._exceptions.CredentialUnavailableError: ManagedIdentityCredential authentication unavailable. The requested identity has not been assigned to this resource. from the Python SDK. I have made no changes to the cluster, the identity or anything in that sort. Have it been auto rolled out?

Steps To Reproduce
Have a AKS cluster running before yesterday where everything was working.

Expected behavior
Still work..

Logs

Environment
Client Version: v1.25.2
Kustomize Version: v4.5.7
Server Version: v1.22.15

Additional context

@thomasfrederikhoeck thomasfrederikhoeck added the bug Something isn't working label Feb 10, 2023
@thomasfrederikhoeck
Copy link
Author

thomasfrederikhoeck commented Feb 10, 2023

After adding adding azure.workload.identity/use: "true" as described here it fixed it https://learn.microsoft.com/en-us/azure/aks/workload-identity-overview#pod-labels which was also the breaking feature described in the release. So it looks like the alpha is what is running on AKS now.

@pinkfloydx33
Copy link

pinkfloydx33 commented Feb 10, 2023

Yeah, same thing happened to us. It seems like we are experience the semantics of the alpha. We were in the process of getting these pod labels added before GA. The funny thing is the AZWI controller still indicates that its running mcr.microsoft.com/oss/azure/workload-identity/webhook:v0.14.0

@aramase
Copy link
Member

aramase commented Feb 10, 2023

Hello 👋🏻 thanks for opening the issue.

AKS is rolling out v0.15.0 in all the regions with the webhook failure policy set to Fail instead of Ignore and the objectSelector azure.workload.identity/use: "true". AFAIK, AKS sent out an email to all the users currently using WI with AKS add-on. @miwithro to confirm!

@aramase aramase added aks and removed bug Something isn't working labels Feb 10, 2023
@pinkfloydx33
Copy link

pinkfloydx33 commented Feb 10, 2023

We got an email a few weeks ago indicating we would need to do it for GA. We were in the process of getting it updated, assuming we had more time.

But even then, the image version still said 14 for the webhook controller so I'm confused why it kicked in.

@glloyd2010f
Copy link

After adding adding azure.workload.identity/use: "true" as described here it fixed it https://dev.azure.com/DSN-AADS/Applications/_build/results?buildId=16332&view=results which was also the breaking feature described in the release. So it looks like the alpha is what is running on AKS now.

Can you provide a copy of the fix in this issue? Trying to implement it and I do not have access to the ADO org.

@pinkfloydx33
Copy link

@glloyd2010f I don't have access either, but the "issue" is that target Pods now require a label in addition to the one required on the ServiceAccount. The fix is to add the azure.workload.identity/use: "true" label to your Pod spec.

Assuming you're using a Deployment, you'd make the following update (with irrelevant properties elided):

kind: Deployment
spec:
  template:
    metadata:
      labels:
        azure.workload.identity/use: 'true'

@thomasfrederikhoeck
Copy link
Author

@glloyd2010f wrong link. I meant this https://learn.microsoft.com/en-us/azure/aks/workload-identity-overview#pod-labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants