Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In 2.0.1 in azs.fabric.admin Disable-AzsScaleUnitNode kicks off ScaleUnitNodesStopMaintenanceMode, while EnableAzsScaleUnitNode kicks off ScaleUnitNodesStartMaintenancemode #23

Closed
nimeader opened this issue Jun 30, 2020 · 5 comments
Closed

In 2.0.1 in azs.fabric.admin Disable-AzsScaleUnitNode kicks off ScaleUnitNodesStopMaintenanceMode, while EnableAzsScaleUnitNode kicks off ScaleUnitNodesStartMaintenancemode #23

nimeader opened this issue Jun 30, 2020 · 5 comments
Assignees
@LingyunSu

Comments

@nimeader
Copy link

In 2.0.1 in azs.fabric.admin Disable-AzsScaleUnitNode kicks off ScaleUnitNodesStopMaintenanceMode, while EnableAzsScaleUnitNode kicks off ScaleUnitNodesStartMaintenancemode, so the cmdlets appear to be switched
@cblackuk
Copy link
Contributor

Thank you!

@bganapa
Copy link
Member

bganapa commented Jun 30, 2020

@LingyunSu The issue is in the renaming of the cmdlets in the readme.md here https://github.com/Azure/azurestack-powershell/blob/master/src/Azs.Fabric.Admin/readme.md Disable should do Start-MaintenanceMode, not Stop-MaintananeMode

@LingyunSu
Copy link
Contributor

LingyunSu commented Jul 14, 2020 •
edited
Loading

Issue fixed. PR:
https://github.com/Azure/azurestack-powershell-pr/pull/205

@LingyunSu
Copy link
Contributor

New PR: #28

@bganapa
Copy link
Member

bganapa commented Aug 10, 2020

The release is out
https://github.com/Azure/azurestack-powershell/releases/tag/v2.0.2-preview

@bganapa bganapa closed this as completed Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LingyunSu LingyunSu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bganapa @cblackuk @LingyunSu @nimeader