Skip to content
This repository has been archived by the owner on Mar 20, 2023. It is now read-only.

Exception in task_file_mover when ingressing files since Shipyard upgrade to 3.7.1 #296

Closed
f-roche opened this issue Aug 1, 2019 · 2 comments
Labels
Milestone

Comments

@f-roche
Copy link

f-roche commented Aug 1, 2019

Hi,
I am having an exception when ingressing files from another task. I have this issue since the upgrade I did from Batch-Shipyard 3.6.0 to 3.7.1.

Here is the exception I got in the stdout.txt file of the task when running the alfpark/batch-shipyard:3.7.1-cargo docker image at task startup:

Traceback (most recent call last):
  File "/opt/batch-shipyard/task_file_mover.py", line 173, in <module>
    main()
  File "/opt/batch-shipyard/task_file_mover.py", line 148, in main
    batch_client = _create_credentials()
  File "/opt/batch-shipyard/task_file_mover.py", line 65, in _create_credentials
    batchauth.SharedKeyCredentials(ba, bakey), base_url=url)
TypeError: __init__() got an unexpected keyword argument 'base_url'

It looks like the call to SharedKeyCredentials is failing because recent version of azure-batch python package changed its constructor parameters (v6.0.0):
Python Azure-Batch package releases
Breaking Renamed the base_url parameter to batch_url on BatchServiceClient class, and it is required now.

@f-roche
Copy link
Author

f-roche commented Aug 1, 2019

after some investigations, it looks like you already fixed it in cbb3689 commit but you did not merge it to your latest release 3.7.1... could you integrate it into a new maintenance release as it affects 3.7.0 and 3.7.1 releases?

@alfpark
Copy link
Collaborator

alfpark commented Aug 5, 2019

3.7.0 was fixed in-situ via manual build and push to Docker Hub (#274). I've done the same for 3.7.1; it was erroneously missed in the release. Please re-deploy your pool and let me know if it's fixed.

The fix will be included properly in 3.8.0 or the next hotfix release.

@alfpark alfpark added the defect label Aug 5, 2019
@alfpark alfpark added this to the 3.8 milestone Aug 5, 2019
@alfpark alfpark closed this as completed Aug 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants