Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode securestring snippet does not use decorator syntax #1959

Closed
DanniJuhl opened this issue Mar 22, 2021 · 3 comments · Fixed by #2019 or #2038
Closed

VSCode securestring snippet does not use decorator syntax #1959

DanniJuhl opened this issue Mar 22, 2021 · 3 comments · Fixed by #2019 or #2038
Assignees
Labels
Milestone

Comments

@DanniJuhl
Copy link

Bicep version
Bicep CLI version 0.3.126 (a5e4c2e)
Describe the bug
In VSCode when using the snippet to set a parameter to secure string, it does not implement it as a decorator, quickly causing a "BCP161: Parameter modifiers are deprecated and will be removed in a future release." error.

To Reproduce

  1. Open Bicep file in VS Code.
  2. Utilize snippets to create a secret string parameter, or let auto-complete assist you.

Result:

  • Actual: Parameter is created/altered to modifier syntax
  • Expected: Parameter is created/altered to decorator syntax

Apologizes for the lowres gif. 😄
bicep-param

@ghost ghost added the Needs: Triage 🔍 label Mar 22, 2021
@anthony-c-martin
Copy link
Member

Good catch, thank you for raising this issue!

@majastrz
Copy link
Member

Indeed!

Implementation note: We will need to use AdditionalTextEdits functionality in LSP to insert the decorator above the declaration.

@bhsubra
Copy link
Contributor

bhsubra commented Mar 30, 2021

FYI, @MarcusFelling

@bhsubra bhsubra closed this as completed Mar 30, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.