Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need MSBuild task to integrate with build systems #290

Closed
majastrz opened this issue Aug 21, 2020 · 6 comments · Fixed by #1992
Closed

Need MSBuild task to integrate with build systems #290

majastrz opened this issue Aug 21, 2020 · 6 comments · Fixed by #1992
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@majastrz
Copy link
Member

This will facilitate internal testing/dogfooding.

@ghost ghost added the Needs: Triage 🔍 label Aug 21, 2020
@majastrz majastrz self-assigned this Aug 21, 2020
@majastrz
Copy link
Member Author

This needs #313 to work right.

@alex-frankel alex-frankel added enhancement New feature or request and removed Needs: Triage 🔍 labels Aug 24, 2020
@alex-frankel alex-frankel added this to the v0.2 milestone Sep 23, 2020
@alex-frankel alex-frankel modified the milestones: v0.2, v0.3 Nov 16, 2020
@alex-frankel
Copy link
Collaborator

@majastrz - Is this addressed by az cli integration? I don't know if that is available in MSBuild

@majastrz
Copy link
Member Author

majastrz commented Mar 3, 2021

No, it's not. There's two things we would need for this:

  1. Publish the compiler as a nuget
  2. A task nuget to wrap the call to the compiler into a native task.

@rynowak
Copy link
Contributor

rynowak commented Mar 3, 2021

You might ultimately want to build an MSBuild task that shells out to the compiler. There's a significant amount of complexity that you take on by trying to load dependencies into the MSBuild process - in particular something like Newtonsoft.Json as a dependency is fraught will peril, and the amount of peril increases with every additional dependency.

I've built a few of these kinds of things. https://github.com/dotnet/sdk/tree/master/src/RazorSdk/Targets

Feel free to pull me in if want to discuss further.

@majastrz
Copy link
Member Author

majastrz commented Mar 3, 2021

Will do. Yeah, the plan is to keep it out of (msbuild) proc for exactly those reasons.

@rynowak
Copy link
Contributor

rynowak commented Mar 3, 2021

Will do. Yeah, the plan is to keep it out of (msbuild) proc for exactly those reasons.

Cool beans. Tis a good plan then 🤣

@alex-frankel alex-frankel modified the milestones: v0.3, v0.4 Mar 8, 2021
@ghost ghost locked as resolved and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants