Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bicep config file to workspace command #5866

Closed
ucheNkadiCode opened this issue Feb 4, 2022 · 4 comments
Closed

Add Bicep config file to workspace command #5866

ucheNkadiCode opened this issue Feb 4, 2022 · 4 comments
Assignees
Labels
devdiv Related to Bicep tooling efforts in DevDiv duplicate This issue or pull request already exists enhancement New feature or request P1 This is planned to be completed before the end of a release
Milestone

Comments

@ucheNkadiCode
Copy link
Contributor

ucheNkadiCode commented Feb 4, 2022

New command for Ctrl + Shift + P
Add new command for create bicep config file

Bicep: Add Bicep configuration file to Workspace

This action will add a bicepconfig.json file to the workspace root of a project. We will not ask the user where to place the file as this command name is explicit.

I would like for the created file to have the simplified version of "no-hardcoded-urls" unless this is absolutely necessary. I expect to just see "warning" rather than a longer list of various azure tenants.
-> #5978

If they already have a configuration file in their workspace root we show an intermediary notification:

"Do you want to overwrite your Bicep configuration file?" [Overwrite] [Cancel]

Related to #5318

@ucheNkadiCode ucheNkadiCode added enhancement New feature or request devdiv Related to Bicep tooling efforts in DevDiv labels Feb 4, 2022
@ucheNkadiCode ucheNkadiCode added this to the v0.5 milestone Feb 4, 2022
@ucheNkadiCode
Copy link
Contributor Author

I am also open to the option of having an optional dialog and in the place holder text it says "Press 'Enter' to add the configuration file to workspace root"

And then it has a "Browse" option underneath. Ultimately users shouldn't have trouble moving their files around. In the meantime, it would be good to discuss with the team if we believe it is a fine "one-size-fits-all" approach to just plop the file in root.

@StephenWeatherford
Copy link
Contributor

Related: #5978

@StephenWeatherford
Copy link
Contributor

StephenWeatherford commented Feb 26, 2022

@ucheNkadiCode ucheNkadiCode added the P1 This is planned to be completed before the end of a release label Mar 16, 2022
@StephenWeatherford
Copy link
Contributor

Dupe of #5711

@StephenWeatherford StephenWeatherford added the duplicate This issue or pull request already exists label Mar 17, 2022
@ghost ghost locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
devdiv Related to Bicep tooling efforts in DevDiv duplicate This issue or pull request already exists enhancement New feature or request P1 This is planned to be completed before the end of a release
Projects
None yet
Development

No branches or pull requests

2 participants