Transient connection error due to connectionStringBuilder[ShardMapUtils.ConnectRetryCount] = 0

[jagwaran]

Hi,

For some reason SQL connection can go wrong and can be resolved if it can try to reconnect. But this library code overrides it and so we are seeing so many issues in prod.
Default ConnectRetryCount is 1, which is overridden to 0 in this library.

        // ConnectRetryCount must not be set (default value is 1)
        if (ShardMapUtils.IsConnectionResiliencySupported && (int)connectionStringBuilder[ShardMapUtils.ConnectRetryCount] > 1)
        {
            throw new ArgumentException(
                StringUtils.FormatInvariant(
                    Errors._ShardMap_OpenConnection_ConnectionStringPropertyDisallowed,
                    ShardMapUtils.ConnectRetryCount),
                "connectionString");
        }

        // Disable connection resiliency if necessary
        if (ShardMapUtils.IsConnectionResiliencySupported)
        {
           [connectionStringBuilder[ShardMapUtils.ConnectRetryCount] = 0;](https://github.com/Azure/elastic-db-tools/blob/master/Src/ElasticScale.Client/ShardManagement/ShardMap/ShardMap.cs)
        }

Is there any update planned to make this as configurable. This will help to resolve many issues.

We don't have DDR mapping changing offline so we are okay to set this ConnectRetryCount to > 1.

[stuartpa]

@jagwaran do you feel comfortable preparing a PR to provide a solution here?