-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commit e74ac06fd1c03 introduces breaking changes #33
Comments
This just broke my builds. |
I had to downgrade to : go get github.com/Azure/go-ntlmssp@v0.0.0-20211209120228-48547f28849e to get my project to build. Added a comment to my go.mod letting me know not to upgrade: require (
// this version works - newer commits have breaking changes - do not update
// github.com/Azure/go-ntlmssp v0.0.0-20211209120228-48547f28849e // indirect
github.com/Azure/go-ntlmssp v0.0.0-20211209120228-48547f28849e // indirect
...
) |
Given that there are no releases for this project (yet), is there any expectation of API stability? Or is this just a heads up to users? |
Since this broke other projects that depend on this it would be nice to have tagged releases or at least tag a 0.x.x version before breaking api. |
Parameters were added to functions, breaking downstream dependencies. eg:
.../go/pkg/mod/github.com/go-ldap/ldap/v3@v3.4.3/bind.go:500:96: not enough arguments in call to ntlmssp.ProcessChallenge
The text was updated successfully, but these errors were encountered: