Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit e74ac06fd1c03 introduces breaking changes #33

Open
iamcaje-psh opened this issue Jun 21, 2022 · 4 comments
Open

Commit e74ac06fd1c03 introduces breaking changes #33

iamcaje-psh opened this issue Jun 21, 2022 · 4 comments

Comments

@iamcaje-psh
Copy link

Parameters were added to functions, breaking downstream dependencies. eg:

.../go/pkg/mod/github.com/go-ldap/ldap/v3@v3.4.3/bind.go:500:96: not enough arguments in call to ntlmssp.ProcessChallenge

@speatzle
Copy link

This just broke my builds.
I made an issue on go-ldap/ldap#381

@iamcaje-psh
Copy link
Author

I had to downgrade to :

go get github.com/Azure/go-ntlmssp@v0.0.0-20211209120228-48547f28849e

to get my project to build. Added a comment to my go.mod letting me know not to upgrade:

require (
	// this version works - newer commits have breaking changes - do not update
	// github.com/Azure/go-ntlmssp v0.0.0-20211209120228-48547f28849e // indirect
	github.com/Azure/go-ntlmssp v0.0.0-20211209120228-48547f28849e // indirect
...
)

@opoplawski
Copy link

Given that there are no releases for this project (yet), is there any expectation of API stability? Or is this just a heads up to users?

@speatzle
Copy link

Since this broke other projects that depend on this it would be nice to have tagged releases or at least tag a 0.x.x version before breaking api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants