Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheckDataDir() checks ADUC_DATA_FOLDER instead of config->dataFolder #657

Open
D-r-P-3-p-p-3-r opened this issue Sep 17, 2024 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation Improvement for future release

Comments

@D-r-P-3-p-p-3-r
Copy link

D-r-P-3-p-p-3-r commented Sep 17, 2024

CheckDataDir() checks ADUC_DATA_FOLDER even though it can be overwritten in du-config.json. It probably should check config->dataFolder.
This is painful when cross-compiling because you're stuck with the built-in path from ADUC_DATA_FOLDER now.
CheckDownloadsDir on the other hand does the right thing and checks config->downloadsFolder.

Btw: https://learn.microsoft.com/en-us/azure/iot-hub-device-update/device-update-configuration-file doesn't explain a bunch of the configuration options available for du-config.json (e.g. dataFolder, extensionsFolder, downloadsFolder).

@jw-msft jw-msft self-assigned this Oct 15, 2024
@OscarLeeMSFT
Copy link

Hi,
Thank you for reporting the issue.
The team will take a look at this and respond further in the next day or two.

@eshashah-msft
Copy link
Contributor

Hi @D-r-P-3-p-p-3-r, This is good feedback and we will track this for our next release of the product (service and agent). We will share more details here once we have a release date. Tracking this as future improvement.

For now, while this can be changed when building the agent code from scratch.

We will address the documentation fixes and update here.

@eshashah-msft eshashah-msft added documentation Improvements or additions to documentation Improvement for future release labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Improvement for future release
Projects
None yet
Development

No branches or pull requests

4 participants