Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix annotations links using github.com even for GHES #201

Open
nv35 opened this issue Jun 22, 2022 · 4 comments
Open

Fix annotations links using github.com even for GHES #201

nv35 opened this issue Jun 22, 2022 · 4 comments
Labels
backlog Planned for future

Comments

@nv35
Copy link
Contributor

nv35 commented Jun 22, 2022

There are few locations were github.com is hardcoded, making it incompatible with github enterprise servers that are hosted on other domains.
From what I understood from these code lines, they are only cosmetic (sent as annotations in deployments).

runUri: `https://github.com/${process.env.GITHUB_REPOSITORY}/actions/runs/${process.env.GITHUB_RUN_ID}`,

return `https://github.com/${process.env.GITHUB_REPOSITORY}/blob/${process.env.GITHUB_SHA}/${pathValue}`;

There is GITHUB_SERVER_URL env var and some others to get the server domain.

@OliverMKing
Copy link
Collaborator

Closed with #200 and action has been released. v4 (v4.1+) has this fix. Thanks!

@nv35
Copy link
Contributor Author

nv35 commented Jun 29, 2022

@OliverMKing the pull request #200 that i've opened is about api calls sent to github.com. This issue is about cosmetic links shown to the user. I don't see any correction yet in the repo.

@OliverMKing
Copy link
Collaborator

I misunderstood what you were saying in #200. Will reopen.

@OliverMKing OliverMKing reopened this Jun 29, 2022
@github-actions
Copy link

This issue is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle Inactive for 14 days label Jul 13, 2022
@OliverMKing OliverMKing added backlog Planned for future and removed idle Inactive for 14 days labels Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Planned for future
Projects
None yet
Development

No branches or pull requests

2 participants