Consolidate spoke network module creation

[glennmusa]

Benefit/Result/Outcome

So that changes are applied universally to all spokes when changes are made and reduce the likelihood of introducing errors or variance between spokes.

Description

Today, we have a module declaration for each of the spoke resource groups, networks, policy assignments, logging activities, and security center enrollments, like this:

missionlz/src/bicep/mlz.bicep

Lines 18 to 46 in b74db11

	module identityResourceGroup './modules/resourceGroup.bicep' = {
	name: 'deploy-identity-rg-${nowUtc}'
	scope: subscription(identitySubscriptionId)
	params: {
	name: identityResourceGroupName
	location: identityLocation
	tags: tags
	}
	}
	module operationsResourceGroup './modules/resourceGroup.bicep' = {
	name: 'deploy-operations-rg-${nowUtc}'
	scope: subscription(operationsSubscriptionId)
	params: {
	name: operationsResourceGroupName
	location: operationsLocation
	tags: tags
	}
	}
	module sharedServicesResourceGroup './modules/resourceGroup.bicep' = {
	name: 'deploy-sharedServices-rg-${nowUtc}'
	scope: subscription(sharedServicesSubscriptionId)
	params: {
	name: sharedServicesResourceGroupName
	location: sharedServicesLocation
	tags: tags
	}
	}

That's a lot of duplication and surface area and risk that changes could differ for each spoke.

Instead, we could use Bicep's loop function to declare those modules just once and provision them the same way for each spoke like this:

missionlz/src/bicep/mlz.bicep

Lines 17 to 25 in 78fe8c7

	module spokeResourceGroups './modules/resourceGroup.bicep' = [for spoke in spokes: {
	name: 'deploy-rg-${spoke.name}-${nowUtc}'
	scope: subscription(spoke.subscriptionId)
	params: {
	name: spoke.resourceGroupName
	location: spoke.location
	tags: tags
	}
	}]

Acceptance Criteria

• Use loops to declare modules a single time and deploy them for many spokes
• The deployment should still take the same parameters and output the same information
• Update any documentation where outputs have changed because of these new structures

[glennmusa]

Proposed these changes in a branch here: main...glenn/consolidateSpokes