Error in privateLink.bicep naming of scope which is currently limited to 16 characters

[shawngib]

Description

There is the potential of the 16 character substring function cutting the name for the private link scope off at a hyphen which is used in the naming of the log analytics workspace and then used in the naming of the scope. This ending in hyphen will cause deployment to fail. In addition the use of substring will fail if the combined log analytics workspace, 8 characters from unique id and prefix of plscope is not the length of the requirested substring. For example requesting a substring of 80 but the string only is 30 will error as well. These lines need re-evaluating :

var privateLinkConnectionName  = substring('plconn${logAnalyticsWorkspaceName }${uniqueData}', 0, 16)
var privateLinkEndpointName = substring('pl${logAnalyticsWorkspaceName }${uniqueData}', 0, 16)
var privateLinkScopeName = substring('plscope${logAnalyticsWorkspaceName }${uniqueData}', 0, 16)
var privateLinkScopeResourceName = substring('plscres${logAnalyticsWorkspaceName }${uniqueData}', 0, 16)

Steps to Reproduce

Steps to reproduce the behavior:

1. Deploy with long prefix

Screenshots

Additional context

Consider:

var privateLinkConnectionName  = take('plconn${logAnalyticsWorkspaceName }${uniqueData}', 80)
var privateLinkEndpointName = take('pl${logAnalyticsWorkspaceName }${uniqueData}', 80)
var privateLinkScopeName = take('plscope${logAnalyticsWorkspaceName }${uniqueData}', 80)
var privateLinkScopeResourceName = take('plscres${logAnalyticsWorkspaceName }${uniqueData}', 80)

Operating System:
Terraform Version:
Cloud (public, Azure Government, etc.):