Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

az what-if and terraform plan PR Validation Checks #94

Closed
glennmusa opened this issue Mar 19, 2021 · 2 comments · Fixed by #437
Closed

az what-if and terraform plan PR Validation Checks #94

glennmusa opened this issue Mar 19, 2021 · 2 comments · Fixed by #437
Assignees
Labels
dev-automation Related to automating builds, the development container, and improving the developer experience.

Comments

@glennmusa
Copy link
Contributor

glennmusa commented Mar 19, 2021

Benefit/Result/Outcome

Know that proposed changes don't affect a working solution.

Description

When a Pull Request is raised, attempt to deploy the source in some known environment, but with unique resources that are destroyed upon success or failure.

This work may depend on #89.

Acceptance Criteria
- run linter (done already by GitHub Actions)
- run bicep build/validate (done already by GitHub Actions)
- run terraform validate (done already by GitHub Action)
- run bicep az deployment what-if (will be done in AzDevOps, go touch a subscription and a cloud see if a deployment is possible)
- run terraform plan (will be done in AzDevOps, go touch a subscription and a cloud see if a deployment is possible)

@brooke-hamilton brooke-hamilton added the core New feature or request label Mar 26, 2021
@brooke-hamilton
Copy link
Contributor

Not all changes require a full deploy and teardown test. For example, documentation updates and issue templates changes. It would be nice if we could have the automation determine when full deploy is required based on the folder(s) containing the changed files.

@brooke-hamilton brooke-hamilton added dev-automation Related to automating builds, the development container, and improving the developer experience. and removed core New feature or request labels Sep 1, 2021
@glennmusa glennmusa changed the title automated deployment for PR validation az what-if and terraform plan PR Validation Checks Oct 21, 2021
@glennmusa
Copy link
Contributor Author

@vidyambala @brooke-hamilton updated the title and acceptance criteria with team decisions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-automation Related to automating builds, the development container, and improving the developer experience.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants