Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade language service next and remove all sorting logic from our end #469

Merged
merged 2 commits into from
Jun 29, 2024
Merged

upgrade language service next and remove all sorting logic from our end #469

merged 2 commits into from
Jun 29, 2024

Conversation

morgilad
Copy link
Collaborator

@morgilad morgilad commented Jun 26, 2024 •
edited
Loading

This PR resolves all sorting issues:

  • Upgraded language-service-next to version 11.6.0 in order to provide OrderText for each completion item and includes a fix for the completion item order when converting from C# to TypeScript.
  • Removed our implementation of creating a sorting text for each completion item.
  • Eliminated our logic for re-sorting completion items, as it is no longer needed.
  • Upgrade the packages to 11.2.0.

I LOVE DELETING CODE!

@morgilad morgilad force-pushed the user/morgilad/intellisense-sorting-fix branch from 97a71a5 to bebb5a4 Compare June 26, 2024 13:27
@sagivf
Copy link
Contributor

sagivf commented Jun 26, 2024

Cide and sweet :)

maxburs
maxburs approved these changes Jun 28, 2024
View reviewed changes
package/src/languageServiceManager/competionItemSort.ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊

@sagivf
Copy link
Contributor

sagivf commented Jun 29, 2024

Cide and sweet :)

 Nice and sweet

@morgilad morgilad merged commit be6b4e5 into master Jun 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagivf sagivf sagivf approved these changes

@maxburs maxburs maxburs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@morgilad @sagivf @maxburs