Provisioner type azure-custom-script-extension should support folder upload

[mohitarora]

Provisioner type azure-custom-script-extension only uploads files from distr_src_path. It should support folder upload as well.

Not sure if that is possible because Azure Custom Script Extension doesn't seem to support folders.

[paulmey]

I'll take a look and see if I can come up with a fix...

[mohitarora]

Any update on this? Can this be supported?

[vladimir-shcherbakov]

The provisioner is able to upload both file and folder code ref
You just need to use a path to a folder instead of a path to a file like in the example

[mohitarora]

Folder is not uploaded, only files at the first level of a folder are uploaded.

https://github.com/MSOpenTech/packer-azure/blob/master/packer/communicator/azureVmCustomScriptExtension/communicator.go#L429

What we were expecting that folder will be uploaded as is with hierarchy maintained. Can that be supported?

[paulmey]

@mohitarora : It's software... almost anything can be supported. PR's are welcome or you can also wait for someone else to fix it. 😉

[vladimir-shcherbakov]

The provisioner uploads data to an Azure storage temporary container and container is able to store files not folder hierarchy. As a workaround - you can pack you folder structure into a zip archive.

[paulmey]

It's a good workaround, but still... The Packer file provisoner uses this capability of the communicator to get files and directories uploaded onto the machine itself. So the current behavior doesn't match that expectation.

P.S. The puppet plugin requires this to work as well.

[paulmey]

hmmm, GitHub broken? notification says @nzspambot commented "@paulmey packer-azure expects only one custom-script provisioner entry that's slightly annoying; is there plans to allow more than one?", but I don't see it here.
Yes, there is a plan to fix that, which includes switching to WinRM for script execution and fixing file/directory upload.

[nzspambot]

@paulmey um yeah wtf? cool thanks on that; good to know 👍