Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chassis][supervisor] show system-health summary fails on the supervisor card #10631

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

mlok-nokia
Copy link
Contributor

@mlok-nokia mlok-nokia commented Apr 20, 2022

Why I did it

Fix the command "sudo show system-health summary" shows the following error on the supervisor card. Fixes #10630

How I did it

This issue is caused by the function get_critical_process_list_from_file() that is not able to handle the empty line in the file critical_processes. On supervisor card, the critical_processes file under swss which is derived from the critical_processes.j2 file and contains empty lines. Added code the check the the re.match result is None, don't continue to process it

How to verify it

  1. boot the image on supervisor card, issue command "sudo show system-health summary". The output should be shown as below:
admin@supervisor:~$ sudo show system-health summary 
System status summary

  System status LED  green
  Services:
    Status: OK
  Hardware:
    Status: OK

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mlok-nokia mlok-nokia requested a review from lguohan as a code owner April 20, 2022 18:38
@zhangyanzhao zhangyanzhao requested a review from rlhui April 27, 2022 15:14
@mlok-nokia mlok-nokia force-pushed the systemhealth-check branch 2 times, most recently from 004b710 to 8370746 Compare May 9, 2022 14:06
@mlok-nokia mlok-nokia force-pushed the systemhealth-check branch from 8370746 to e92c59d Compare May 13, 2022 18:58
@mlok-nokia mlok-nokia force-pushed the systemhealth-check branch from e92c59d to ee2ff55 Compare June 30, 2022 20:30
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 3, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mlok-nokia / name: Marty Y. Lok (f706420f07c97b21930ee448fb0cbfdccfd81ed1)

@mlok-nokia mlok-nokia force-pushed the systemhealth-check branch 2 times, most recently from f706420 to f64227a Compare August 26, 2022 16:19
…sor card

Signed-off-by: mlok <marty.lok@nokia.com>
@mlok-nokia
Copy link
Contributor Author

@judyjoseph @prgeor @abdosi Please help to review at this PR. It is applicable to 202205 branch also. Thanks.

@abdosi abdosi merged commit 57ff7a2 into sonic-net:master Sep 22, 2022
yxieca pushed a commit that referenced this pull request Oct 3, 2022
…sor card (#10631)

Fix the command "sudo show system-health summary" shows the following error on the supervisor card. Fixes #10630
@mlok-nokia mlok-nokia deleted the systemhealth-check branch January 26, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[chassis][supervisor] show system-health summary failed on the supervisor card
4 participants