Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support clounix asic for pegatron fn8656 product #12440

Open
wants to merge 3 commits into
base: 202012
Choose a base branch
from

Conversation

wolflowbj
Copy link

Signed-off-by: Zhou,Junde piter.zhou@163.com

Why I did it

support clounix asic for pegatron fn8656 product which will be deployed in internal data center verry soon.

How I did it

support clounix asic for pegatron fn8656 product which will be deployed in internal data center verry soon.

How to verify it

support clounix asic for pegatron fn8656 product which will be deployed in internal data center verry soon.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@lgtm-com
Copy link

lgtm-com bot commented Oct 18, 2022

This pull request introduces 35 alerts when merging 6f383cd into a00773a - view on LGTM.com

new alerts:

  • 24 for Wrong number of arguments in a class instantiation
  • 3 for Except block handles 'BaseException'
  • 2 for Backspace escape in regular expression
  • 1 for Unnecessary pass
  • 1 for Use of the return value of a procedure
  • 1 for Module imports itself
  • 1 for 'import *' may pollute namespace
  • 1 for Wrong number of arguments in a call
  • 1 for Binding a socket to all network interfaces

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 18, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@lgtm-com
Copy link

lgtm-com bot commented Oct 18, 2022

This pull request introduces 35 alerts when merging aa3e19e0bd12814d96b9458a6966d126c2a97c82 into a00773a - view on LGTM.com

new alerts:

  • 24 for Wrong number of arguments in a class instantiation
  • 3 for Except block handles 'BaseException'
  • 2 for Backspace escape in regular expression
  • 1 for Unnecessary pass
  • 1 for Use of the return value of a procedure
  • 1 for Module imports itself
  • 1 for 'import *' may pollute namespace
  • 1 for Wrong number of arguments in a call
  • 1 for Binding a socket to all network interfaces

@lgtm-com
Copy link

lgtm-com bot commented Oct 21, 2022

This pull request introduces 35 alerts when merging 0db6014 into d8d0436 - view on LGTM.com

new alerts:

  • 24 for Wrong number of arguments in a class instantiation
  • 3 for Except block handles 'BaseException'
  • 2 for Backspace escape in regular expression
  • 1 for Unnecessary pass
  • 1 for Use of the return value of a procedure
  • 1 for Module imports itself
  • 1 for 'import *' may pollute namespace
  • 1 for Wrong number of arguments in a call
  • 1 for Binding a socket to all network interfaces

@wolflowbj wolflowbj marked this pull request as ready for review October 22, 2022 13:52
@wolflowbj
Copy link
Author

@lguohan clould you please help to merge for this pull request ? any comments for this? thanks.

@yxieca yxieca requested a review from sujinmkang December 5, 2022 04:31
@yxieca
Copy link
Contributor

yxieca commented Dec 5, 2022

@wolflowbj can you please look into the LGTM alerts and fix accordingly?

@wolflowbj
Copy link
Author

an you please look into the LGTM alerts and fix accordingly?

thanks for your quick response. I will fix it later.

@lgtm-com
Copy link

lgtm-com bot commented Dec 6, 2022

This pull request introduces 24 alerts when merging fa72b343b28579d22c7a39798c21c123b1a7bf77 into e15acb5 - view on LGTM.com

new alerts:

  • 24 for Wrong number of arguments in a class instantiation

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@wolflowbj
Copy link
Author

an you please look into the LGTM alerts and fix accordingly?

thanks for your quick response. I will fix it later.
24 alerts are caused by the LGTM checked the function from broadcom and mellanox. it seems we shouldn't do this. how can we fix the issue, or ignore this alerts?
@yxieca any comments for the alerts? thanks.

@Battier
Copy link

Battier commented Dec 7, 2022

@sujinmkang
Could you please kindly review this PR? Thanks in advance.

@Battier
Copy link

Battier commented Dec 16, 2022

@sujinmkang
Hi Sujin,
Could you please kindly take a look this PR? Thanks for your helping.

Signed-off-by: Zhou,Junde <piter.zhou@163.com>
Signed-off-by: Zhou,Junde <piter.zhou@163.com>
Signed-off-by: Zhou,Junde <piter.zhou@163.com>
@wolflowbj
Copy link
Author

@yxieca yxieca thanks for review comments last time. and we failed to reach [sujinmkang]. could you please help to review it again or involve anyone who could help us. thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants