[Yang] [frrcfgd] Add SONiC support to enable isisd and configure ISIS #13527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchoate54
force-pushed
the
frr-isis-configuration-support
branch
4 times, most recently
from
f007374 to
e7a46ec
Compare
cchoate54
force-pushed
the
frr-isis-configuration-support
branch
2 times, most recently
from
2baa0b7 to
0e27c09
Compare
cchoate54
force-pushed
the
frr-isis-configuration-support
branch
from
0e27c09 to
6efc2b7
Compare
cchoate54
changed the title
cchoate54
changed the title
cchoate54
changed the title
cchoate54
changed the title
cchoate54
force-pushed
the
frr-isis-configuration-support
branch
2 times, most recently
from
28f21c2 to
a9ab226
Compare
… implementation * Update /src/sonic-yang-models: Add SONiC FRR-ISIS YANG model and ISIS YANG validation tests * Update /dockers/docker-fpm-frr: FRR-ISIS config template files and isisd enabled by default in the FRR container * Update /files/image_config/copp: Enable ISIS trap messages * Update /src/sonic-frr-mgmt-framework: Added support for ISIS tables in frrcfgd and extended frrcfgd unit tests for FRR-ISIS configs Signed-off-by: cchoate54@gmail.com
|
Commenter does not have sufficient privileges for PR 13527 in repo sonic-net/sonic-buildimage |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
cchoate54
force-pushed
the
frr-isis-configuration-support
branch
2 times, most recently
from
c14110c to
6ed89f8
Compare
* Update /src/sonic-yang-models: Update SONiC FRR-ISIS YANG model and ISIS YANG validation tests for PR comments * Update /dockers/docker-fpm-frr: Remove template files in this directory since isisd will only be enabled when frrcfgd is in use. Update docker_init.sh to configure isis in the COPP_TABLE when frrcfgd is enabled * Update /src/sonic-frr-mgmt-framework: Added support for frrcfgd and frrcfgd unit tests for changes made to the ISIS YANG model based on PR comments. Add a new template to configure isis in the COPP_TABLE when frrcfgd is enabled Signed-off-by: cchoate54@gmail.com
cchoate54
force-pushed
the
frr-isis-configuration-support
branch
from
6ed89f8 to
98747b8
Compare
cchoate54
force-pushed
the
frr-isis-configuration-support
branch
from
751f729 to
cdda940
Compare
|
Any chance that this PR merge into master? |
|
I'd like to inquire why you've only created the LEVEL table for ISIS instances and not for interfaces. Interface configurations also involve level settings, yet you haven't distinguished them within the ISIS_INTERFACE table. What was the rationale behind separating the level configuration of ISIS instances into its own table? This approach results in three tables for a single ISIS instance, which increases maintenance costs and complicates processing logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Include SONiC configuration support to configure ISIS within the FRR container
How I did it
How to verify it
Changes have been tested with Unittests as well as system tests performed on a VS image
Which release branch to backport (provide reason below if selected)
N/A
Description for the changelog
Add SONiC support to configure ISIS using FRR's ISIS implementation
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and
TBD
Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
TBD
A picture of a cute animal (not mandatory but encouraged)