[Build] Add a space character to seperate the url and hash value #14146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xumia
force-pushed
the
fix-seperator
branch
7 times, most recently
from
32c032a to
45b674b
Compare
| if '.blob.core.' in package and sp: | ||
| if len(sp) > 1: | ||
| continue | ||
| elif len(sp) == 1 and sp[0] != 'r' and sp[0] != 'rl': |
There was a problem hiding this comment.
Can we just change from '==' to ' =='?
The logic to validate privilege maybe change in future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
[Build] Add a space character to seperate the url and hash value for Azure Storage SAS Key
If it contains high privilege info, it will be skipped.
How I did it
It only has impact on url packages, does not have impact on the other packages, such as git, deb.
If the url is azure blob storage and contains SAS key, check the privilege and the format.
For checking the privilege part, it makes sure it only contains read or list permission only, if other permissions, skip the url.
For the SAS format, if the SAS ends with '&sp=r' or '&sp=rl', then additional space character will be added in the end of the url, when using the url, the additional character will be removed.
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)