-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support to enable chassisd from the platform, which is necessary for SmartSwitch #18676
Conversation
Summary seems to be having a typo? Is it: |
Done |
@@ -6,7 +6,16 @@ if [ "$EUID" -ne 0 ] ; then | |||
exit 1 | |||
fi | |||
|
|||
if [ -f /etc/sonic/chassisdb.conf ]; then | |||
PLATFORM="$(sonic-cfggen -d -v DEVICE_METADATA.localhost.platform)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MSFT proposed a way to check if the system is a Smart Switch by accessing the platform.json
file. The presence of the DPUS
table means that the system is a Smart Switch NPU. The presence of the DPU
table means that the system is a Smart Switch DPU: Smart Switch IP Address Assignment.
This approach is used in various places by the Smart Switch Database service. I suggest using it here as well for consistency and to minimize the number of files that describe the system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E.g. #17562
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will follow that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as commented
Added support to enable chassisd form the platform which is required for SmartSwitch
Why I did it
SmartSwitch platform requires chassisd to run on fixed platform.
How I did it
Added a flag "include_chassisd" which is enabled from the platform and will be enabled for SmartSwitch platform
How to verify iit
Which release branch to backport (provide reason below if selected)
202311
Tested branch (Please provide the tested image version)
202311
Description for the changelog
{% if include_chassisd or not skip_chassisd and IS_MODULAR_CHASSIS == 1 %}
Link to config_db schema for YANG module changes
This PMON HLD like may be useful https://github.com/sonic-net/SONiC/blob/56d97c6e72884a3108618b191dc4570634304eaa/doc/smart-switch/pmon/smartswitch-pmon.md
A picture of a cute animal (not mandatory but encouraged)