Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to enable chassisd from the platform, which is necessary for SmartSwitch #18676

Closed
wants to merge 0 commits into from

Conversation

rameshraghupathy
Copy link
Contributor

Added support to enable chassisd form the platform which is required for SmartSwitch

Why I did it

SmartSwitch platform requires chassisd to run on fixed platform.

How I did it

Added a flag "include_chassisd" which is enabled from the platform and will be enabled for SmartSwitch platform

How to verify iit

  1. Added the flag in the code
  2. Modified the platform SmartSwitch "../platform/pmon_daemon_control.json" file to enable it
  3. Built an image and when loaded chassisd strated running on SmartSwitch image

Which release branch to backport (provide reason below if selected)

202311

Tested branch (Please provide the tested image version)

202311

Description for the changelog

{% if include_chassisd or not skip_chassisd and IS_MODULAR_CHASSIS == 1 %}

Link to config_db schema for YANG module changes

This PMON HLD like may be useful https://github.com/sonic-net/SONiC/blob/56d97c6e72884a3108618b191dc4570634304eaa/doc/smart-switch/pmon/smartswitch-pmon.md

A picture of a cute animal (not mandatory but encouraged)

@vvolam
Copy link
Contributor

vvolam commented Jun 19, 2024

Summary seems to be having a typo? Is it:
"Added support to enable chassisd from the platform, which is necessary for SmartSwitch"?

@rameshraghupathy rameshraghupathy changed the title Added support to enable chassisd form the platform which is required for SmartSwitch Added support to enable chassisd from the platform, which is necessary for SmartSwitch Jul 9, 2024
@rameshraghupathy
Copy link
Contributor Author

Summary seems to be having a typo? Is it: "Added support to enable chassisd from the platform, which is necessary for SmartSwitch"?

Done

@@ -6,7 +6,16 @@ if [ "$EUID" -ne 0 ] ; then
exit 1
fi

if [ -f /etc/sonic/chassisdb.conf ]; then
PLATFORM="$(sonic-cfggen -d -v DEVICE_METADATA.localhost.platform)"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSFT proposed a way to check if the system is a Smart Switch by accessing the platform.json file. The presence of the DPUS table means that the system is a Smart Switch NPU. The presence of the DPU table means that the system is a Smart Switch DPU: Smart Switch IP Address Assignment.

This approach is used in various places by the Smart Switch Database service. I suggest using it here as well for consistency and to minimize the number of files that describe the system.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E.g. #17562

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will follow that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #19729 and addressed these comments in #19729

Copy link
Collaborator

@oleksandrivantsiv oleksandrivantsiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as commented

@rameshraghupathy
Copy link
Contributor Author

Created #19729 and addressed these comments in #19729. #18676 18676 was created using the 202311 branch which is not where the smartswitch changes are applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants