YANG Model for DHCP DoS Mitigation #18873
Conversation
ridahanif96
changed the title
|
@ganglyu @qiluo-msft Hi, can you please help find reviewer for this PR. Thanks in advance! |
|
@ganglyu @qiluo-msft Can you please help review this PR. Thanks in advance. |
|
@ganglyu @qiluo-msft kindly help review this PR, thanks in advance! |
| leaf dhcp_rate_limit { | ||
| description "DHCP DOS Mitigation Rate with default value 300"; | ||
| type uint32 { | ||
| range 0..800000; |
There was a problem hiding this comment.
Why do you use 800000 as max value?
There was a problem hiding this comment.
There is no specific max standard range for DHCP DOS Range. We added a reasonably large maximum range vale to cater all device rate limit scenarios.
There was a problem hiding this comment.
It seems that we don't really need this range.
There was a problem hiding this comment.
Yes it can work without range as well. If suggested, we can remove range.
| } | ||
| }, | ||
|
|
||
| "PORT_INVALID_DHCP_RATE_LIMIT": { |
There was a problem hiding this comment.
OK, Will modify existing testcases
There was a problem hiding this comment.
LGTM
sonic-net/SONiC#1651
HLD is not approved, please wait for other reviewers
|
Hi @ganglyu can you pls help merge this PR. HLD is already merged |
I'm not authorized to merge this PR. |
|
Hi @qiluo-msft can you pls help review and merge this PR. |
|
@yaqiangz Could you help review? |
|
@qiluo-msft pls help merge this one |
|
@qiluo-msft pls help review and merge this PR |
#### Why I did it Added Support for DHCP rate limit #### How I did it Modifed sonic-port.yang by adding a new leaf for dhcp rate limit #### How to verify it Updated Config DB and YANG model
Why I did it
Added Support for DHCP rate limit
How I did it
Modifed sonic-port.yang by adding a new leaf for dhcp rate limit
How to verify it
Updated Config DB and YANG model