[Mellanox] Block setting the watchdog in the case that watchdog period is longer than the max period supported by the platform #18980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…than the max period supported by the platform Signed-off-by: Kebo Liu <kebol@nvidia.com>
Junchao-Mellanox
approved these changes
May 16, 2024
|
/azpw run ms_conflict |
|
/AzurePipelines run ms_conflict |
|
No pipelines are associated with this pull request. |
prgeor
approved these changes
May 21, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
May 23, 2024
…d is longer than the max period supported by the platform sonic-net#18980) - Why I did it Currently the platform API will arm the watchdog w/o checking the required watchdog period. If the watchdog period is longer than the max period supported by the platform, it will cause issue on some specific platform. - How I did it Verify whether the required watchdog period is longer than the max period supported, if yes then return failure. - How to verify it test with watchdog util to set the watchdog period to different values including larger than the max supported period, all case passed. Signed-off-by: Kebo Liu <kebol@nvidia.com>
|
Cherry-pick PR to 202311: #19053 |
mssonicbld
pushed a commit
that referenced
this pull request
May 23, 2024
…d is longer than the max period supported by the platform #18980) - Why I did it Currently the platform API will arm the watchdog w/o checking the required watchdog period. If the watchdog period is longer than the max period supported by the platform, it will cause issue on some specific platform. - How I did it Verify whether the required watchdog period is longer than the max period supported, if yes then return failure. - How to verify it test with watchdog util to set the watchdog period to different values including larger than the max supported period, all case passed. Signed-off-by: Kebo Liu <kebol@nvidia.com>
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Currently the platform API will arm the watchdog w/o checking the required watchdog period. If the watchdog period is longer than the max period supported by the platform, it will cause issue on some specific platform.
Work item tracking
How I did it
Verify whether the required watchdog period is longer than the max period supported, if yes then return failure.
How to verify it
test with watchdog util to set the watchdog period to different values including larger than the max supported period, all case passed.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)