Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding port speed in port_config.ini for the platforms AG9032 and Quanta IX1B #2923

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adding port speed in port_config.ini for the platforms AG9032 and Quanta IX1B #2923

wants to merge 3 commits into from

Conversation

Prasanth-KV
Copy link

@Prasanth-KV Prasanth-KV commented May 20, 2019 •
edited
Loading

- What I did
Made sure that the default port speed is been populated in config_db during first initialization for the hardware platforms, AS5712, AS7712, AS7816, AS7326, AG9032 and Quanta IX1B.
- How I did it
Speed is been added in port_config.ini of the platforms - AS5712, AS7712, AS7816, AS7326, AG9032 and Quanta IX1B
- How to verify it

  1. Bring-up the system with an image having these changes.
  2. show interface status - This should show default port speed for all the interfaces.
  3. Create a port-channel
  4. show interface status - this should show aggregate speed of member ports as port-channel speed.

- Description for the changelog
Speed is been added in port_config.ini of the platforms - AS5712, AS7712, AS7816, AS7326, AG9032 and Quanta IX1B

- A picture of a cute animal (not mandatory but encouraged)

@Prasanth-KV
Root cause: The default port speed has to be read from port_config.in…
f562a82 
…i during first boot. Since speed is missing in port_config.ini, config_db does not have the speed and port-channel speed calculation fails.

Solution: speed is been added in port_config.ini of the platforms - AS5712, AS7712, AS7816, AS7326, AG9032 and Quanta IX4
@msftclas
Copy link

msftclas commented May 20, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@lguohan lguohan requested a review from roylee123 May 20, 2019 16:48
@stcheng
Copy link
Contributor

stcheng commented May 20, 2019

Could you change the name of the commit? Better to state what's changed in this commit.

@Prasanth-KV Prasanth-KV changed the title show interface status command fails when port-channel exists. Adding port speed in port_config.ini for the platforms AS5712, AS7712, AS7816, AS7326, AG9032 and Quanta IX4 May 21, 2019
@Prasanth-KV
Copy link
Author

Could you change the name of the commit? Better to state what's changed in this commit.

Changed the name of the commit.

@Prasanth-KV
Copy link
Author

Can someone please help in triggering build again for Broadcom and VS platforms? The failure is due name resolution failure.

distutils.errors.DistutilsError: Download error for https://files.pythonhosted.org/packages/38/d8/3789eb77845f8700bd12943835fdbd79b693c2f009cdcb985d7d33884f6c/setuptools_scm-3.3.3-py3.5.egg#sha256=38c714af0f04999f12c419b39bdae9969ebe94af40b230b0999afb5004a8deab: [Errno -3] Temporary failure in name resolution

@roylee123
Copy link
Collaborator

roylee123 commented May 23, 2019 •
edited
Loading

Hi all,
For the platforms whose port_config.ini have no "index" column, such as as7712 and as7816, you have to add "index" started from 0.
Or sfputilbase.py(src/sonic-platform-common) will treat 4th column as index, and makes sfputil out of function.

@jonathantsai-qci
Copy link
Contributor

@Prasanth-KV
Just kindly remind. you change Quanta project is IX1B, not IX4. I will push IX4 on Github after IX1B's stretch is been merged. Thanks.

@Prasanth-KV
Root cause: The default port speed has to be read from port_config.in…
1e092c6 
…i during first boot. Since speed is missing in port_config.ini, config_db does not have the speed and port-channel speed calculation fails.

Solution: speed is been added in port_config.ini of the platforms - AS5712, AS7712, AS7816, AS7326, AG9032 and Quanta IX4
@Prasanth-KV Prasanth-KV changed the title Adding port speed in port_config.ini for the platforms AS5712, AS7712, AS7816, AS7326, AG9032 and Quanta IX4 Adding port speed in port_config.ini for the platforms AS5712, AS7712, AS7816, AS7326, AG9032 and Quanta IX1B May 27, 2019
roylee123
roylee123 previously approved these changes May 29, 2019
View reviewed changes
Copy link
Collaborator

@roylee123 roylee123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's OK for accton device, AS5712, AS7712, AS7816 and AS7326.
But no guarantee to AG9032 and Quanta IX1B.

@Prasanth-KV
Copy link
Author

Thanks @roylee123
I would request @StanleyCi , @jonathantsai-qci and @nealtai to review the remaining files.

@lguohan
Copy link
Collaborator

lguohan commented Jul 18, 2019

retest vsimage please

@lguohan
Copy link
Collaborator

lguohan commented Jul 18, 2019

I do not see much progress. @Prasanth-KV, can you split the PR for accton, so that we can merge?

@roylee123 roylee123 mentioned this pull request Jul 24, 2019
Merged
@Prasanth-KV
Copy link
Author

I do not see much progress. @Prasanth-KV, can you split the PR for accton, so that we can merge?

#3213 contains these changes for Accton platforms and it is already merged. I will remove those files from this PR. We can merge this PR if Delta and Quanta port_config.ini gets reviewed.

@Prasanth-KV Prasanth-KV changed the title Adding port speed in port_config.ini for the platforms AS5712, AS7712, AS7816, AS7326, AG9032 and Quanta IX1B Adding port speed in port_config.ini for the platforms AG9032 and Quanta IX1B Jul 25, 2019
@Prasanth-KV Prasanth-KV requested a review from jleveque as a code owner February 6, 2021 20:29
@Prasanth-KV Prasanth-KV requested a review from a team as a code owner June 10, 2022 02:01
mssonicbld added a commit that referenced this pull request Nov 8, 2023
@mssonicbld
[submodule] Update submodule sonic-swss to the latest HEAD automatica…
72a464d 
…lly (#17115)

#### Why I did it
src/sonic-swss
```
* 2b02c249 - (HEAD -> master, origin/master, origin/HEAD) Send hearbeat during warm reboot freese (#2923) (81 minutes ago) [Hua Liu]
```
#### How I did it
#### How to verify it
#### Description for the changelog
mssonicbld added a commit that referenced this pull request Nov 12, 2023
@mssonicbld
[submodule] Update submodule sonic-swss to the latest HEAD automatica…
a3f8153 
…lly (#17146)

#### Why I did it
src/sonic-swss
```
* 65720c1a - (HEAD -> 202305, origin/202305) Send hearbeat during warm reboot freese (#2923) (#2956) (14 hours ago) [Hua Liu]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan left review comments

@roylee123 roylee123 roylee123 left review comments

@jleveque jleveque Awaiting requested review from jleveque

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Enhancement ➕ Platform: Accton
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Prasanth-KV @msftclas @stcheng @roylee123 @jonathantsai-qci @lguohan