Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config.bcm for accton_as7816_64x to support port breakout. #3638

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add config.bcm for accton_as7816_64x to support port breakout. #3638

wants to merge 1 commit into from

Conversation

chiourung
Copy link
Contributor

Add four config.bcm for row1, row2, row3 and row4.

Signed-off-by: chiourung_huang chiourung_huang@edge-core.com

- What I did
Modify the config.bcm for breakout.

- How I did it
Reserve the port mapping for breakout.

- How to verify it
Load the config.bcm to the DUT, and check the status

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Add four config.bcm for row1, row2, row3 and row4.

Signed-off-by: chiourung_huang <chiourung_huang@edge-core.com>
lguohan
lguohan previously approved these changes Oct 21, 2019
@lguohan
Copy link
Collaborator

lguohan commented Oct 21, 2019

what is row{1,2,3,4}? is this for dynamic port breakout?

@chiourung
Copy link
Contributor Author

There is a limitation for port number. Not all ports can be breakout. So user can choose which row can be breakout. There are 64 ports for as7816_64x, and 16 ports for one row. For now, the new config.bcm can be modified for breakout easily. For future, when the broadcom SAI ready, the new config.bcm don't need any modified for breakout.

@lguohan
Copy link
Collaborator

lguohan commented Nov 9, 2019

we do not want multiple config.bcm for a single hardware sku.

@CharlieChenEC
Copy link
Contributor

we do not want multiple config.bcm for a single hardware sku.

I think it is flexible enough to change the pointer in the file "sai.profile" to decide which config.bcm shall be used. Could you tell me what is the reason that "multiple config.bcm" is not acceptable?

@CharlieChenEC
Copy link
Contributor

we do not want multiple config.bcm for a single hardware sku.

I think it is flexible enough to change the pointer in the file "sai.profile" to decide which config.bcm shall be used. Could you tell me what is the reason that "multiple config.bcm" is not acceptable?

@lguohan Could you please provide your concern of using multiple config.bcm? What is your suggestion to deal with the complex port breakout restriction without using this proposed method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants