[snmp] Upgrading to snmpd v5.8 #3994
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
changed the title
qiluo-msft
reviewed
Jan 9, 2020
| wget -NO net-snmp_$(SNMPD_VERSION_FULL).dsc "https://sonicstorage.blob.core.windows.net/packages/net-snmp_5.7.3+dfsg-1.5.dsc?sv=2015-04-05&sr=b&sig=vDAYAKlwi7JjF%2FesdJUyf4VIEXPsCfLhqqTqNr75zBs%3D&se=2030-10-12T13%3A59%3A45Z&sp=r" | ||
| wget -NO net-snmp_$(SNMPD_VERSION).orig.tar.xz "https://sonicstorage.blob.core.windows.net/packages/net-snmp_5.7.3+dfsg.orig.tar.xz?sv=2015-04-05&sr=b&sig=UjIh%2FTcHrIEzEV7a%2BV2ZP4ks3xHlAA3wqyxkyV7Ms8I%3D&se=2030-10-12T13%3A58%3A19Z&sp=r" | ||
| wget -NO net-snmp_$(SNMPD_VERSION_FULL).debian.tar.xz "https://sonicstorage.blob.core.windows.net/packages/net-snmp_5.7.3+dfsg-1.5.debian.tar.xz?sv=2015-04-05&sr=b&sig=xJkmxjtKXYcPe4yR%2FuCA0TXUfT40rj4XUMBaiK9CjsA%3D&se=2030-10-12T14%3A00%3A15Z&sp=r" | ||
| wget -NO net-snmp_$(SNMPD_VERSION_FULL).dsc "https://sonicstorage.blob.core.windows.net/packages/net-snmp_5.8+dfsg-2.dsc?sv=2015-04-05&sr=b&sig=BXvY%2BFaOQ7utLcU%2FubM%2F1Fm%2FAxinYHjjw6iE9MzwJD4%3D&se=2033-09-16T21%3A48%3A19Z&sp=r" |
There was a problem hiding this comment.
https://sonicstorage.blob.core.windows.net/packages/net-snmp_5.8+dfsg-2.dsc?sv=2015-04-05&sr=b&sig=BXvY%2BFaOQ7utLcU%2FubM%2F1Fm%2FAxinYHjjw6iE9MzwJD4%3D&se=2033-09-16T21%3A48%3A19Z&sp=r [](start = 46, length = 186)
Could you have some comment in code, to show the original download URL?
like dget http://XXXXX.dsc
So in future, dev will know where to find new version. #Closed
qiluo-msft
reviewed
Jan 9, 2020
| dpkg-source -x net-snmp_$(SNMPD_VERSION_FULL).dsc | ||
|
|
||
| pushd net-snmp-$(SNMPD_VERSION) | ||
| git init | ||
| git add -f * | ||
| git add -f . |
There was a problem hiding this comment.
git add -f . [](start = 1, length = 12)
What is diff? #Closed
There was a problem hiding this comment.
add * does not add hidden files.
Also delete the folder patch-5.7.3+dfsg? #Closed Refers to: src/snmpd/Makefile:33 in e4791bc. [](commit_id = e4791bc5ff07717e7d363a64feb881ba516c347d, deletion_comment = False) |
qiluo-msft
previously approved these changes
Jan 9, 2020
tahmed-dev
force-pushed
the
taahme/update-snmp-to-v5.8
branch
3 times, most recently
from
5f6258b to
1a4e75e
Compare
pavel-shirshov
previously approved these changes
Jan 15, 2020
|
retest vsimage please |
Upgraded from snmp v5.7.3 to snmp v5.8. Status of snmp v5.7.3 patches:
0001-SNMP-Stop-spamming-logs-with-statfs-permission-denie.patch - recreated
0002-at.c-properly-check-return-status-from-realloc.-Than.patch - already integrated and the file moved to agent/mibgroup/mibII/data_access/at_linux.c
0003-CHANGES-BUG-2743-snmpd-crashes-when-receiving-a-GetN.patch - already integrated
0004-Disable-SNMPv1.patch - recreated
0005-Port-OpenSSL-1.1.0-with-support-for-1.0.2.patch - it is integrated, enabled via autoconfigure after checking the OS capabilities
0006-From-Jiri-Cervenka-snmpd-Fixed-agentx-crashing-and-or-freezing-on-timeout.patch
- already integrated
0007-Linux-VRF-5.7.3-Support.patch - non trivial patch, will for help to port it
0008-Enable-macro-DEB_BUILD_ARCH_OS-in-order-to-build-ipv.patch - recreated
Also, Added new patch in order to get the new lib compiling for a case when
SNMPv1 is disabled while SNMPv2 is enabled.
signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
tahmed-dev
force-pushed
the
taahme/update-snmp-to-v5.8
branch
from
2e6de09 to
b23cfee
Compare
00410e5 (HEAD, origin/master, origin/HEAD) [mgmt-framework] Update Swagger URL to repo1.maven.org (sonic-net#37) 7562028 Merge pull request sonic-net#36 from Azure/Arlo cd22b4d (origin/Arlo) Added the certificate check to quiet 7fbcd46 Changed the swagger website to https 5d1041f Added sonic-mgmt-framework deb install to install the contents of sonic-mgmt-framework deb package (sonic-net#30) 229fe69 Added sonic-mgmt-framework deb install to install the contents of sonic-mgmt-framework deb package signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
|
the snmp related test are failing which are not supposed to be. can you check if this is introduced due to snmp package upgrade? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded from snmp v5.7.3 to snmp v5.8. Status of snmp v5.7.3 patches:
0001-SNMP-Stop-spamming-logs-with-statfs-permission-denie.patch - recreated
0002-at.c-properly-check-return-status-from-realloc.-Than.patch - already integrated and the file moved to agent/mibgroup/mibII/data_access/at_linux.c
0003-CHANGES-BUG-2743-snmpd-crashes-when-receiving-a-GetN.patch - already integrated
0004-Disable-SNMPv1.patch - recreated
0005-Port-OpenSSL-1.1.0-with-support-for-1.0.2.patch - it is integrated, enabled via autoconfigure after checking the OS capabilities
0006-From-Jiri-Cervenka-snmpd-Fixed-agentx-crashing-and-or-freezing-on-timeout.patch
- already integrated
0007-Linux-VRF-5.7.3-Support.patch - ported from https://sourceforge.net/p/net-snmp/patches/1376/attachment/linux-vrf-5.8.0.patch
0008-Enable-macro-DEB_BUILD_ARCH_OS-in-order-to-build-ipv.patch - recreated
Also, Added new patch in order to get the new lib compiling for a case when
SNMPv1 is disabled while SNMPv2 is enabled.
signed-off-by: Tamer Ahmed tamer.ahmed@microsoft.com
- What I did
Packaging of snmp v5
- How I did it
Ported Debian packaging of snmp v5.8 from https://packages.debian.org/sid/libsnmp-dev
Added SONiC patches on top of it
Created new patch for compilation error in the case of SNMPv1 is not defined while SNMPv2 is.
Ported of patch '0007-Linux-VRF-5.7.3-Support.patch' contributed by Dell, is not trivial.
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)