Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker-vs] Install dependencies for testing DPB #4960

Merged
merged 2 commits into from
Jul 14, 2020

Conversation

samaity
Copy link
Collaborator

@samaity samaity commented Jul 13, 2020

Signed-off-by: Sangita Maity sangitamaity0211@gmail.com

- Why I did it
Added xmltodict and jsondiff packages needed to run vs test cases successfully for DPB.

sonic-utilities PR #766 has a dependency on it.
Getting error without this fix

- How I did it
Added necessary packages into Dockerfile for vs docker.

- How to verify it

Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>
@samaity
Copy link
Collaborator Author

samaity commented Jul 13, 2020

@zhenggen-xu, need help in leveling this PR with Port Breakout and Request for 202006 Branch

Signed-off-by: Sangita Maity <sangitamaity0211@gmail.com>
@zhenggen-xu
Copy link
Collaborator

retest this please

@samaity
Copy link
Collaborator Author

samaity commented Jul 14, 2020

retest vsimage please

@jleveque
Copy link
Contributor

Retest mellanox please

@jleveque jleveque changed the title Adding neccessary package for testing DPB on sonic vs image Install dependencies for testing DPB on SONiC vs image Jul 14, 2020
@jleveque jleveque changed the title Install dependencies for testing DPB on SONiC vs image [docker-vs] Install dependencies for testing DPB Jul 14, 2020
@jleveque jleveque merged commit 6ebcfb2 into sonic-net:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants