Update process-reboot-cause to save the reboot-cause to state-db #5562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
reviewed
Oct 8, 2020
jleveque
suggested changes
Oct 9, 2020
|
retest mellanox please! |
|
@jleveque Can you review this again? |
jleveque
suggested changes
Oct 13, 2020
jleveque
suggested changes
Oct 14, 2020
jleveque
suggested changes
Oct 15, 2020
jleveque
suggested changes
Oct 15, 2020
jleveque
suggested changes
Oct 16, 2020
jleveque
suggested changes
Oct 21, 2020
jleveque
suggested changes
Oct 22, 2020
jleveque
suggested changes
Oct 23, 2020
There was a problem hiding this comment.
Today I merged new changes to create two new packages, sonic-host-services and sonic-host-services-data
Can you please move the determine-reboot-cause and process-reboot-cause scripts into the former and move the service files into the latter?
See here: #5694
Note that you will also need to make sure the scripts are Python 3-compliant
|
@jleveque I can open a new PR for the migration to sonic-host-service package after I submitting this PR. |
|
retest broadcom please |
1 similar comment
|
retest broadcom please |
…5784) - Convert docker-wait-any script to Python 3 - Install Python 3 Docker Engine API in host OS
jleveque
suggested changes
Nov 5, 2020
| @@ -0,0 +1,98 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
Please change shebang to #!/usr/bin/env python3 and ensure script is Python 3-compliant.
|
will open a new PR after rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
To make the reboot cause history information available for telemetry service, during processing the reboot-cause on boot, the information is saved in state-db.
- How I did it
Split the
process-reboot-cause serviceinto two services:determine-reboot-causeandprocess-reboot-causeDetermine the reboot-cause based on the hardware/software reboot-cause information and save it into a file with time stamp when it's determined.
Read the saved reboot-cause files up to 10 files (after time-sorted) from "/host/reboot-cause/history" directory and save them to state-db.
- How to verify it
Tested in DUT using Cli commands ( introduced and modified with this PR : Add
show reboot-historysonic-utilities#1154) and check the state-db with redis-cli.- Which release branch to backport (provide reason below if selected)
- Description for the changelog
HLD : sonic-net/SONiC#669
- A picture of a cute animal (not mandatory but encouraged)