cJSON debian package #5810
Closed
cJSON debian package #5810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Includes build scripts to download and package cJSON v1.7.11 as a debian package - libcjson_1.7.11_amd64.deb. Components that need C/C++ JSON parser can use this tool. 2) Mgmt-framework now depends cJSON deb - required for an upcoming enhancement in CLISH CLI.
lguohan
reviewed
Nov 4, 2020
| $(addprefix $(DEST)/, $(MAIN_TARGET)): $(DEST)/% : | ||
| # Obtain libcjson | ||
| rm -rf ./cJSON-$(LIBCJSON_VERSION) | ||
| wget -N "https://github.com/DaveGamble/cJSON/archive/v$(LIBCJSON_VERSION).tar.gz" |
There was a problem hiding this comment.
@xumia, does this align with reproduciable build design?
|
retest vs please |
|
retest vsimage please |
This was referenced Nov 5, 2020
Closed
|
retest vsimage please |
|
We realized that libcjson is already part of buster distribution - https://packages.debian.org/buster/libcjson1. Hence a private package is not required. Mgmt framework will use the standard libcjson package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
An upcoming enhancement to mgmt-framework CLI requires opensource cJOSN
library for parsing JSON data. Adding as a deb package makes it easy to
use in other components too.
- How I did it
Added build scripts to download and package cJSON v1.7.11 as a
debian package - libcjson_1.7.11_amd64.deb. Components that need C/C++
JSON parser can use this tool.
- How to verify it
Full build
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
cJSON debian package
- A picture of a cute animal (not mandatory but encouraged)