Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sonic-cli start script and resolve package dependencies #5920

Closed
wants to merge 4 commits into from

Conversation

kwangsuk
Copy link
Contributor

@kwangsuk kwangsuk commented Nov 13, 2020

- Why I did it
As part of mgmt-framework CLI enhancement - sonic-net/sonic-mgmt-framework#72

- How I did it
update the bash script to launch Klish
update the Dockerfile.j2 to resolve dependent packages

- How to verify it
Incremental buster build with sonic-net/sonic-mgmt-framework#72

- Which release branch to backport (provide reason below if selected)

201811
201911
202006

- Description for the changelog

Update the Klish start script:
support CLI session timeout, prompt string with hostname, disallow CLI for the root user, disallow user to enter commands in click prompt after reboot command is issued in KLISH mode
add dependent libraries for Kish parser enhancement

@jeff-yin
Copy link
Collaborator

retest broadcom please

@jeff-yin
Copy link
Collaborator

retest vsimage please

@@ -7,7 +7,7 @@ RUN [ -f /etc/rsyslog.conf ] && sed -ri "s/%syslogtag%/$docker_container_name#%s
ENV DEBIAN_FRONTEND=noninteractive

RUN apt-get update && \
apt-get install -y g++ python-dev libxml2
apt-get install -y g++ python-dev libxml2 libcurl3-gnutls libpython2.7 libcjson-dev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are not you moving to Python3 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade to python3.7 in sonic-cli is in progress. A PR will be opened soon after the pending PRs related to Klish parser - sonic-net/sonic-mgmt-framework#72, sonic-net/sonic-mgmt-framework#73 - get merged.

@jeff-yin
Copy link
Collaborator

jeff-yin commented Dec 2, 2020

retest vsimage please

@kwangsuk kwangsuk closed this Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants