Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic_debian_extension] install docker_image_ctl.j2 template in the … #5937

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

stepanblyschak
Copy link
Collaborator

@stepanblyschak stepanblyschak commented Nov 16, 2020

…image templates

Signed-off-by: Stepan Blyshchak stepanb@nvidia.com

This PR is part of SONiC Application Extension

- Why I did it
SONiC Package Manager will require to auto-generate the start script using that template. For that, we need this template to be recorded in SONiC filesystem.

- How I did it
Copy the template in SONiC filesystem during image build.

- How to verify it
Build an image and cat /usr/share/sonic/templates/docker_image_ctl.j2.

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

…image templates

Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
@stepanblyschak stepanblyschak changed the title [sonic_debian_exntesion] install docker_image_ctl.j2 template in the … [sonic_debian_extension] install docker_image_ctl.j2 template in the … Dec 15, 2020
@stepanblyschak
Copy link
Collaborator Author

/AzurePipelines run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 5937 in repo Azure/sonic-buildimage

@renukamanavalan
Copy link
Contributor

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@renukamanavalan
Copy link
Contributor

retest vsimage please

1 similar comment
@renukamanavalan
Copy link
Contributor

retest vsimage please

@renukamanavalan
Copy link
Contributor

retest vsimage please.

@renukamanavalan
Copy link
Contributor

retest vsimage please

1 similar comment
@yxieca
Copy link
Contributor

yxieca commented Feb 5, 2021

retest vsimage please

@renukamanavalan
Copy link
Contributor

/Azurepipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

/Azurepipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik
Copy link
Collaborator

Note: I have restarted the pipelines but the tests are not really restarted. Any way to do so?

@lguohan lguohan merged commit 12c03c4 into sonic-net:master Feb 25, 2021
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
…image templates (sonic-net#5937)

SONiC Package Manager will require to auto-generate the start script using that template. For that, we need this template to be recorded in SONiC filesystem.

Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
@stepanblyschak stepanblyschak deleted the include_docker_template branch September 23, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants