[hwsku] set optional fields for child ports #6660
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmytroxshevchuk
changed the title
dmytroxshevchuk
changed the title
lguohan
reviewed
Feb 3, 2021
| @@ -255,7 +255,8 @@ def parse_platform_json_file(hwsku_json_file, platform_json_file): | |||
| # take optional fields from hwsku.json | |||
| for key, item in hwsku_dict[INTF_KEY][intf].items(): | |||
| if key in OPTIONAL_HWSKU_ATTRIBUTES: | |||
| child_ports.get(intf)[key] = item | |||
| for child_key in child_ports.keys(): | |||
| child_ports.get(child_key)[key] = item | |||
There was a problem hiding this comment.
can you add a unit test for catch such error?
There was a problem hiding this comment.
@lguohan , done, please check
dmytroxshevchuk
force-pushed
the
opt_fields_for_child_ports
branch
from
04a09ec
to
94ede95
Compare
akokhan
previously approved these changes
Feb 10, 2021
|
@lguohan , reminder for review |
|
@lguohan please merge |
|
@lguohan @daall @jleveque @qiluo-msft please review and merge this PR. |
dmytroxshevchuk
force-pushed
the
opt_fields_for_child_ports
branch
2 times, most recently
from
d0f33e9
to
a788f8e
Compare
|
This pull request introduces 1 alert when merging a788f8e243b798658c8f0c7e1dfddb78af640369 into 070b020 - view on LGTM.com new alerts:
|
dmytroxshevchuk
force-pushed
the
opt_fields_for_child_ports
branch
from
a788f8e
to
5de0919
Compare
|
Can someone take a look, please? |
qiluo-msft
approved these changes
Apr 4, 2021
|
@lguohan, please merge |
zhenggen-xu
reviewed
May 12, 2021
| @@ -226,6 +226,16 @@ def get_child_ports(interface, breakout_mode, platform_json_file): | |||
| parent_intf_id = int(re.search("Ethernet(\d+)", interface).group(1)) | |||
| for k in match_list: | |||
| offset = gen_port_config(child_ports, parent_intf_id, index, alias_list, lanes, k, offset) | |||
|
|
|||
| if hwsku_dict is None: | |||
There was a problem hiding this comment.
As mentioned in #7578 , what we really need is to enhance the design to support other fields in platform.json.
zhenggen-xu
suggested changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
Currently after split ports using
modein hwsku, optional parameters set only for parent ports.Example:
if we set
autoneg,fecin hwsku forEthernet0like this:config_db will be:
Its not really correct because of we need set this parameters for all generate interfaces.
After fix, config_db will be:
- How I did it
Add optional fields for child ports.
- How to verify it
Add optional fields in hwsku.json and generate config_db
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)