Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pbh]: Add YANG model #7461

Merged
merged 11 commits into from
Jul 19, 2021
Merged

[pbh]: Add YANG model #7461

merged 11 commits into from
Jul 19, 2021

Conversation

nazariig
Copy link
Collaborator

@nazariig nazariig commented Apr 28, 2021 •
edited
Loading

Why I did it

  • Done as part of PBH development

How I did it

  • Added PBH YANG model

How to verify it

  1. Add PBH configuration
  2. Run DPB

Which release branch to backport (provide reason below if selected)

  • 202106

Description for the changelog

  • N/A

A picture of a cute animal (not mandatory but encouraged)

      .---.        .-----------
     /     \  __  /    ------
    / /     \(  )/    -----
   //////   ' \/ `   ---
  //// / // :    : ---
 // /   /  /`    '--
//          //..\\
       ====UU====UU====
           '//||\\`
             ''``

This was referenced Apr 28, 2021
Closed
Merged
@nazariig nazariig added the YANG YANG model related changes label Apr 28, 2021
@liat-grozovik
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik liat-grozovik requested review from lguohan and removed request for liat-grozovik May 9, 2021 07:40
@liat-grozovik
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@venkatmahalingam
Copy link
Collaborator

Please add UT test cases.

@venkatmahalingam
Copy link
Collaborator

Looks like this PR is work-in-progress(Draft), please change the Draft status for review to begin.

@nazariig nazariig marked this pull request as ready for review May 25, 2021 10:21
@nazariig
Copy link
Collaborator Author

Please add UT test cases.

@venkatmahalingam done

@nazariig nazariig force-pushed the master-pbh-yang branch 2 times, most recently from aeec165 to 81361ec Compare May 27, 2021 11:35
@nazariig
Copy link
Collaborator Author

#7733

@nazariig
Copy link
Collaborator Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 7461 in repo Azure/sonic-buildimage

@nazariig nazariig mentioned this pull request Jun 18, 2021
Closed
@nazariig nazariig requested a review from prsunny June 29, 2021 22:43
@nazariig
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nazariig
[pbh]: Add YANG model.
26c11cb 
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@nazariig
[pbh]: YANG model rev01.
b01d801 
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@nazariig
[pbh]: YANG model rev02.
40ad22d 
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@nazariig
[pbh]: YANG model rev03.
148a77c 
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@nazariig
[pbh]: Add YANG UT.
c38a58b 
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@nazariig
[pbh]: YANG model rev04.
b48f00f 
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@nazariig
[pbh]: Add YANG UT rev01.
e0e9a0a 
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@nazariig
[pbh]: YANG model rev05.
38876d2 
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@nazariig
[pbh]: Add YANG UT rev02.
0a4a977 
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@nazariig
[pbh]: YANG model rev06.
ab84cfc 
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@nazariig
[pbh]: Add YANG UT rev03.
bc53bb6 
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@nazariig
Copy link
Collaborator Author

@anish-n please review & merge

anish-n
anish-n approved these changes Jul 16, 2021
View reviewed changes
Copy link
Contributor

@anish-n anish-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High level looks good to me, I am not very familiar with Yang models, so I would recommend merging only after someone with Yang model expertise has also reviewed and signed off.

@nazariig
Copy link
Collaborator Author

@prsunny please help to merge

@prsunny prsunny merged commit 91ff807 into sonic-net:master Jul 19, 2021
@vadymhlushko-mlnx vadymhlushko-mlnx mentioned this pull request Jul 22, 2021
Merged
1 task
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
@nazariig
[pbh]: Add YANG model (sonic-net#7461)
86eba5a 
* [pbh]: Add YANG model.
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rathnasabapathyv rathnasabapathyv rathnasabapathyv left review comments

@praveen-li praveen-li praveen-li left review comments

@venkatmahalingam venkatmahalingam venkatmahalingam left review comments

@anish-n anish-n anish-n approved these changes

@prsunny prsunny prsunny approved these changes

@volodymyrsamotiy volodymyrsamotiy Awaiting requested review from volodymyrsamotiy

@lguohan lguohan Awaiting requested review from lguohan

Assignees
No one assigned
Labels
YANG YANG model related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@nazariig @liat-grozovik @venkatmahalingam @anshuv-mfst @mssonicbld @prsunny @praveen-li @anish-n @rathnasabapathyv