-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AS5835-54X] Fix chassis health led bug #8276
Open
jostar-yang
wants to merge
20
commits into
sonic-net:202012
Choose a base branch
from
jostar-yang:as5835-54x_20210728_fix_health_led
base: 202012
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[AS5835-54X] Fix chassis health led bug #8276
jostar-yang
wants to merge
20
commits into
sonic-net:202012
from
jostar-yang:as5835-54x_20210728_fix_health_led
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jostar Yang <jostar_yang@accton.com.tw>
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
This pull request introduces 2 alerts when merging ab17762 into 967d8ab - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 791178f into 2eb8fe3 - view on LGTM.com new alerts:
|
/azpw run |
/AzurePipelines run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
/azpw run |
/AzurePipelines run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
This pull request introduces 2 alerts when merging f19d8a7 into aa4379d - view on LGTM.com new alerts:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jostar Yang jostar_yang@accton.com.tw
Why I did it
Chassis health led has bug and it will let show led fail when health found PSU is not power.
How I did it
Fix chassis.py code.
How to verify it
Plug-out one PSU and check "show system-health summary". Led should how amber
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)