-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tjcw fix vtysh for -f - #9148
Tjcw fix vtysh for -f - #9148
Conversation
Apologies for forgetting to sign off the commit with '-s' |
5209d3d
to
4ed4a43
Compare
@lguohan please review this PR |
@lguohan what is the next step for this PR ? I think it is ready for review and merge, but if you think it needs further developement please let me know what area I should attend to. Thanks ! Chris Ward, IBM. |
1 similar comment
@lguohan what is the next step for this PR ? I think it is ready for review and merge, but if you think it needs further developement please let me know what area I should attend to. Thanks ! Chris Ward, IBM. |
@lguohan what is the next step for this PR ? IBM would like it integrated into master so that I do not have to maintain a separate branch. |
Pick up revisions from master
Signed-off-by: Chris Ward <tjcw@uk.ibm.com>
Signed-off-by: Chris Ward <tjcw@uk.ibm.com>
24ce8d5
to
cf79497
Compare
is this upstreamed to frr community? |
I am no longer working in this area. I believe the fix would be useful, but I cannot progress it myself. Closing. |
Why I did it
I needed vtysh to be able to take input from a pipe, i.e. something like
{
echo list
echo list
} | vtysh -f -
How I did it
I made changes to the file handling in vtysh so that piped input works; the old code had a dependency on the -f value representing a real file and not a pipe, I removed this dependency
How to verify it
Try
{
echo list
echo list
} | docker -i bgp vtysh
to the SONiC shell
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)