Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translib phase I changes #11

Merged
merged 5 commits into from
Jun 26, 2020
Merged

Translib phase I changes #11

merged 5 commits into from
Jun 26, 2020

Conversation

anand-kumar-subramanian
Copy link
Contributor

  • Go formatting changes
  • Subscribe API standardized to take structures as input and output (This is a dependency for REST and gNMI PRs)
  • Action(RPC ) API body (Implementation will be done in future PRs (This is a dependency for REST and gNMI PRs)
  • REST query parameters field support in translib (This is a dependency for REST)
  • Changes to have write disabled for DB operation (Need to integrate with DB access layer once that PR comes in)
  • Versioning bare minimum actual support will come in a separate PR (This is a dependency for REST and gNMI PRs)
  • Static analysis tool fixes

renukamanavalan
renukamanavalan reviewed Jun 26, 2020
View reviewed changes
translib/app_interface.go Outdated Show resolved Hide resolved
translib/app_interface.go Outdated Show resolved Hide resolved
translib/translib.go Show resolved Hide resolved
@renukamanavalan renukamanavalan merged commit 89d95a1 into sonic-net:master Jun 26, 2020
renukamanavalan pushed a commit that referenced this pull request Mar 17, 2021
@dutta-partha
CVL Changes #11: Enabling mandatory node check (#40)
cfc86de 
Enabling mandatory node check and related test cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renukamanavalan renukamanavalan renukamanavalan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anand-kumar-subramanian @renukamanavalan