DB-Layer fixes/enhancements #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
a-barboza
commented
Sep 30, 2020
a-barboza
commented
- Added additional DBs
- NoDelete option used (Set|Mod)Entry
- MultiDB changes
- GetKeysByPattern(), Publish(), RunScript()
- DeleteKeys() bug fix
* Added additional DBs * NoDelete option used (Set|Mod)Entry * MultiDB changes * GetKeysByPattern(), Publish(), RunScript() * DeleteKeys() bug fix
* Go Test fix for Multi-DB Config File missing.
|
@a-barboza, tests failed due to missing database_config.json file in the test environment. Please include |
Yes, I saw this. I had already included this in the translib/db/db_test.go go test file. But there are other go tests besides the db/db_test.go that do not include the file. Trying to see if there are other ways to provide a default if the file is not found |
* Added Multi-DB Test Config file tools/test/database_config.json * DB Layer uses the sonic-mgmt-common database_config.json file as a last resort if the file specified by DB_CONFIG_PATH environment variable, or the default file cannot be found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.