Mgmt reorg -- move YANGs, translib, transformer and CVL to sonic-mgmt-common #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Moved yangs, translib, transformer, cvl and go patch files into the new sonic-mgmt-common repo. CLI, REST server and yang->openapi->go server code generator tools are retained. CLI and rest directories are moved outside src directory to be consistent with go sources. 2) Implemented gomodule based go dependency management. All patches are applied on vendor directory using patch script from mgmt-common. 3) Yang-to-openapi and swagger codegen tools to consume yangs from sonic-mgmt-common repo. Symlink to sonic-mgmt-common/models/yang directory is created during build for easy access. 4) Now sonic-mgmt-framework.deb does not inclue yang and cvl schema files. They are installed from sonic-mgmt-common.deb in docker image.
|
This pull request fixes 2 alerts when merging 4cecf57 into 32fa9d8 - view on LGTM.com fixed alerts:
|
renukamanavalan
approved these changes
Jun 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
New repo sonic-mgmt-common is introduced for the common translib related code which will be used by both REST and gNMI services. Common code includes YANGs, translib infra, transformer infra, app modules and CVL infra. This commit moves all such common code to sonic-mgmt-common.
- How I did it
Moved YANGs, translib, transformer, CVL and go patch files into the new sonic-mgmt-common repo. CLI, REST server, YANG-to-OpenAPI spec generator and OpenAPI code generator tools are retained.
Implemented gomodule based go dependency management for REST server.
CLI and rest directories are moved outside src directory to be consistent with go sources.
- How to verify it
Full build and incremental builds
Basic ACL and interface opreations through REST, KLISH CLI and gNMI
Gotest
- Description for the changelog
Moved YANGs, translib, transformer and cvl code to sonic-mgmt-common.