[test_system_health.py] Adjust test cases of system health #4562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I01710a47112b483fbedc5d0ff83b70bed5c44c70
Change-Id: Idd1ca2133593c45ce18de0e82a40281ab557561d
keboliu
approved these changes
Oct 26, 2021
wangxin
approved these changes
Oct 27, 2021
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@lguohan should we fix "monit summary -B"? |
qiluo-msft
reviewed
Oct 28, 2021
|
|
||
| critical_process = random.sample(running_critical_process, 1)[0] | ||
| with ProcessExitContext(duthost, container, critical_process): | ||
| time.sleep(DEFAULT_INTERVAL) |
There was a problem hiding this comment.
System-health poll critical process status every 60 seconds, so it has to wait 60 second here.
qiluo-msft
reviewed
Oct 28, 2021
| @@ -348,3 +369,18 @@ def __exit__(self, exc_type, exc_val, exc_tb): | |||
| :return: | |||
| """ | |||
| self.dut.command('mv -f {} {}'.format(self.backup_config, self.origin_config)) | |||
|
|
|||
|
|
|||
| class ProcessExitContext: | |||
|
@qiluo-msft could you please approve and sign off? |
4 tasks
AntonHryshchuk
pushed a commit
to AntonHryshchuk/sonic-mgmt
that referenced
this pull request
Jan 4, 2022
…#4562) What is the motivation for this PR? Command monit summary -B can no longer display the status for each critical process, system-health should not depend on it and need find a way to monitor the status of critical processes. The PR is to adjust the test case and cover the change. How did you do it? Adjust test case to check critical process without monit Stop a critical process and check system-health status How did you verify/test it? Run the regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on sonic-net/sonic-buildimage#9068
Change-Id: I01710a47112b483fbedc5d0ff83b70bed5c44c70
Description of PR
Summary:
Command monit summary -B can no longer display the status for each critical process, system-health should not depend on it and need find a way to monitor the status of critical processes. The PR is to adjust the test case and cover the change.
Type of change
Back port request
Approach
What is the motivation for this PR?
Command monit summary -B can no longer display the status for each critical process, system-health should not depend on it and need find a way to monitor the status of critical processes. The PR is to adjust the test case and cover the change.
How did you do it?
How did you verify/test it?
Run the regression
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation