Handle RJ45 port when checking presence #5927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keboliu
previously approved these changes
Jul 7, 2022
stephenxs
force-pushed
the
fix-RJ45-presence-state
branch
from
a9f2cbc to
1926ec6
Compare
- Expose 'type' to show_interfaces - Handle expected presence status differently between 'RJ45' and normal ports Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
stephenxs
force-pushed
the
fix-RJ45-presence-state
branch
from
1926ec6 to
efc318b
Compare
|
Hi |
keboliu
approved these changes
Aug 15, 2022
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@sujinmkang would you please help to review? |
|
@prgeor kindly reminder to review and signoff. this is needed for complete support of rj45 in 202205. |
|
@stephenxs can you add more details to the PRs? The PR tempalate is empty:- |
@prgeor Done. |
prgeor
approved these changes
Sep 8, 2022
Azarack
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Oct 17, 2022
* Handle RJ45 port when checking presence - Expose 'type' to show_interfaces - Handle expected presence status differently between 'RJ45' and normal ports Signed-off-by: Stephen Sun <stephens@nvidia.com> * Leverage module "interface" to calculate number of RJ45 ports Signed-off-by: Stephen Sun <stephens@nvidia.com> Signed-off-by: Stephen Sun <stephens@nvidia.com>
allen-xf
pushed a commit
to allen-xf/sonic-mgmt
that referenced
this pull request
Oct 28, 2022
* Handle RJ45 port when checking presence - Expose 'type' to show_interfaces - Handle expected presence status differently between 'RJ45' and normal ports Signed-off-by: Stephen Sun <stephens@nvidia.com> * Leverage module "interface" to calculate number of RJ45 ports Signed-off-by: Stephen Sun <stephens@nvidia.com> Signed-off-by: Stephen Sun <stephens@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Signed-off-by: Stephen Sun stephens@nvidia.com
Type of change
Back port request
Approach
What is the motivation for this PR?
Expose
typeof a port toshow_interfaces, which enables other modules to leveragetypeto implement certain functionalities. Eg. In platform API test, the number ofRJ45ports can be calculated via counting the ports whose type isRJ45.How did you do it?
Parse the output of
show interface statusand extracttypefield and then push it into the dict.Do not try parsing it if the output is in the old format.
How did you verify/test it?
Manually test and regression test.
Any platform specific information?
N/A
Supported testbed topology if it's a new test case?
N/A
Documentation