Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[psud] Bug fix: the fields that are not supported by vendor should be "N/A" in STATE_DB #168

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

stephenxs
Copy link
Collaborator

Description

Bug fix: the fields that are not supported by the vendor should be "N/A" in STATE_DB

  • Initialize fields as "N/A" and set the field to "N/A" for those not supported by vendor API
  • Update set_voltage, set_temperature, treating "N/A" instead of None as invalid values
  • Update unit test cases accordingly

Signed-off-by: Stephen Sun stephens@nvidia.com

Motivation and Context

How Has This Been Tested?

Manually test and regression test

Additional Information (Optional)

…in STATE_DB

- Initialize fields as "N/A" and set the field to "N/A" for those not supported by vendor API
- Update set_voltage, set_temperature, treating "N/A" instead of None as invalid values
- Update unit test cases accordingly

Signed-off-by: Stephen Sun <stephens@nvidia.com>
@jleveque jleveque merged commit 450b7d7 into sonic-net:master Mar 30, 2021
@liat-grozovik
Copy link
Collaborator

@stephenxs can you please update submodule? if this is also relevant to 202012 please specify.

@stephenxs stephenxs deleted the fix-not-supported-field-2 branch March 30, 2021 20:49
vdahiya12 pushed a commit to vdahiya12/sonic-platform-daemons that referenced this pull request Apr 4, 2022
sonic-net/sonic-buildimage#6768 change the kvm artifact name from kvm to vs

Signed-off-by: Guohan Lu <lguohan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants