Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add thermal control daemon to monitor FAN and thermal status and run thermal policy #49

Merged
merged 24 commits into from
Feb 14, 2020
Merged

Add thermal control daemon to monitor FAN and thermal status and run thermal policy #49

merged 24 commits into from
Feb 14, 2020

Conversation

Junchao-Mellanox
Copy link
Collaborator

What I did?

  1. Add FanUpdater to get fan information and write it to database
  2. Add TemperUpdater to get temperature information and write it to database
  3. Add ThermalControlDaemon to run the thermal policy

How to verify?

  1. show platform fanstatus
  2. show platform temperature
  3. View syslog make sure thermalctld is up and there is no error logs

Junchao-Mellanox and others added 18 commits November 28, 2019 11:02
@Junchao-Mellanox
Add thermal control daemon for thermal control feature
ae19c4d
@Junchao-Mellanox
Fix issue: error syntx in for loop
c177043
@Junchao-Mellanox
Set fan led according to fan status
f44f859
@Junchao-Mellanox
Fix comments find by code review
cd085c9
@Junchao-Mellanox
Add thermal policy support
26c112b
@Junchao-Mellanox
Fix code review comments
619242d
@Junchao-Mellanox
fix typo on logging status change, for abnormal case, it should be wa…
eced1af 
…rning instead of notice
@Junchao-Mellanox
Fix issue found by test
e3e6e29
@Junchao-Mellanox
Merge branch 'thermal-control' into thermal-policy
bf2c80b
@Junchao-Mellanox
Fix issue found by manual test
5c57207
@Junchao-Mellanox
1.fix issues found during manual test; 2.add unit test for thermalctld
c65916d
@Junchao-Mellanox
Caught exceptions for thermal policy to avoid daemon crash
1cb5824
@Junchao-Mellanox
1. Fix error calculation of FAN over speed and under speed; 2. Makes …
3dfe7e5 
…logs clearer
@Junchao-Mellanox
Initialize thermal_manager before use it
8b638e2
@Junchao-Mellanox
Change update log level from info to debug
5219680
@Junchao-Mellanox
add get_high_critical_threshold and get_low_critical_threshold
f82e014
@Junchao-Mellanox
add code to initialize thermal control algorithm
9cb311c
@Junchao-Mellanox
fix issue found by pipeline test
15d4fde
@Junchao-Mellanox Junchao-Mellanox marked this pull request as ready for review January 7, 2020 10:07
@liat-grozovik
Copy link
Collaborator

@stepanblyschak please review as well

jleveque
jleveque suggested changes Jan 30, 2020
View reviewed changes
sonic-thermalctld/setup.cfg Outdated Show resolved Hide resolved
jleveque
jleveque suggested changes Feb 1, 2020
View reviewed changes
sonic-thermalctld/scripts/thermalctld Outdated Show resolved Hide resolved
sonic-thermalctld/scripts/thermalctld Outdated Show resolved Hide resolved
@Junchao-Mellanox Junchao-Mellanox mentioned this pull request Feb 4, 2020
Merged
jleveque
jleveque suggested changes Feb 11, 2020
View reviewed changes
sonic-thermalctld/scripts/thermalctld Outdated Show resolved Hide resolved
@jleveque
Copy link
Contributor

@stepanblyschak to review as well, per Liat above.

@jleveque jleveque merged commit fc455a7 into sonic-net:master Feb 14, 2020
@wendani
Copy link

wendani commented Apr 17, 2020

Request for 201911 with sonic-net/sonic-buildimage#3949 @jleveque @abdosi

abdosi pushed a commit that referenced this pull request Apr 19, 2020
@Junchao-Mellanox @abdosi
Add thermal control daemon to monitor FAN and thermal status and run …
8ccad0c 
…thermal policy (#49)
@Junchao-Mellanox Junchao-Mellanox deleted the thermal-policy branch October 29, 2021 01:47
vdahiya12 pushed a commit to vdahiya12/sonic-platform-daemons that referenced this pull request Apr 4, 2022
@keboliu @jleveque
sync change to sonic_platform_base/sonic_sfp and create symbol link (s…
4442b94 
…onic-net#49)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepanblyschak stepanblyschak stepanblyschak approved these changes

@keboliu keboliu keboliu approved these changes

@jleveque jleveque jleveque approved these changes

Assignees
No one assigned
Labels
Enhancement Included in 201911 Branch Request for 201911 Branch thermalctld
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Junchao-Mellanox @liat-grozovik @jleveque @wendani @keboliu @stepanblyschak @abdosi