-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vslib: add support for read-only port capabilities #1038
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dante Su <dante.su@broadcom.com>
This was referenced May 5, 2022
please fix compilation issues:
|
It depends on the following PR in the SAI master branch, can I update the SAI submodule to use the latest commit of master branch? |
yes, you can raise PR to update submodule |
Signed-off-by: Dante Su <dante.su@broadcom.com>
kcudnik
approved these changes
May 13, 2022
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
* vslib: add support for read-only port capabilities Signed-off-by: Dante Su <dante.su@broadcom.com> * vslib: Drop LT capability query Signed-off-by: Dante Su <dante.su@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of HLD: sonic-net/SONiC#924, sonic-net/SONiC#925
What I did
Add port capability query for AutoNeg and Link-Training
Why I did it
Fix the VS test failure for the port AutoNeg and Link-Training capability queries
How I verified it
Ran the sonic-swss/tests/test_port_an.py to verify