[unittests] Add unittests for SwitchStateBaseHostif #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Sep 23, 2022
| @@ -46,7 +47,7 @@ int SwitchStateBase::vs_create_tap_device( | |||
|
|
|||
| const char *tundev = "/dev/net/tun"; | |||
|
|
|||
| int fd = open(tundev, O_RDWR); | |||
| int fd = saimeta::System::open(tundev, O_RDWR); | |||
There was a problem hiding this comment.
wrapper on system function is need to simulate function succes on unittests, it seems to me an ugly solution but i could not find better one, any suggestions ?
There was a problem hiding this comment.
Is the performance a concern? Does debug build help the coverage anyhow?
There was a problem hiding this comment.
there is no performance impact since those apis are not on critical paths, coverage is achieved in places required by #1110
|
ut fail probably not related to the change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.