For sflow feature, SAI changes needed for sonic-vs platform #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ling is configured on a port.
This is applicable only for sflow feature running on sonic VS.
Signed-off-by: Rakesh Datta <rakesh.datta@dell.com>
|
|
rakeshdatta
changed the title
* Update: modified some words to pass the spell-check error Signed-off-by: Rakesh Datta <rakesh.datta@dell.com>
kcudnik
requested changes
Aug 7, 2019
rakeshdatta
force-pushed
the
sflow-vslib
branch
from
6107f11
to
b3a5380
Compare
* Bugfix: Updation of sampling rate is creating multiple 'tc filter' entries Signed-off-by: Rakesh Datta <rakesh.datta@dell.com>
rakeshdatta
force-pushed
the
sflow-vslib
branch
from
b3a5380
to
8a96ebf
Compare
kcudnik
approved these changes
Aug 15, 2019
prsunny
approved these changes
Sep 3, 2019
rakeshdatta
changed the title
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
When sflow is configured using CLI or other supported mechanisms, the orch-agent invokes the SAI API set_port_attribute(). For the sflow feature, his API is used to set the SAI_PORT_ATTR_INGRESS_SAMPLEPACKET_ENABLE attribute of a netdev port. The value stored for this attribute is a samplepacket object, which essentially contains various sampling attributes (sampling rate, sampler group etc.) associated with the port. When sampling is disabled on a port, the SAI_PORT_ATTR_INGRESS_SAMPLEPACKET_ENABLE attribute is set to a null object. When sampling is enabled on a port, the SAI_PORT_ATTR_INGRESS_SAMPLEPACKET_ENABLE attribute is set to a valid samplepacket object. For sonic-vs, in the absence of a real ASIC programming, the 'tc' command is used instead to configure the sampling parameters inside the kernel. In this PR we invoke the appropriate 'tc' command, based on the requested config actions (disable or enable or update). Signed-off-by: Rakesh Datta <rakesh.datta@dell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add SAI library changes to support sflow in sonic-vs.
When sflow is configured using CLI or other supported mechanisms, the orch-agent invokes
the SAI API set_port_attribute(). For the sflow feature, his API is used to set the SAI_PORT_ATTR_INGRESS_SAMPLEPACKET_ENABLE attribute of a netdev port. The value stored for this attribute is a samplepacket object, which essentially contains various sampling attributes (sampling rate, sampler group etc.) associated with the port.
When sampling is disabled on a port, the SAI_PORT_ATTR_INGRESS_SAMPLEPACKET_ENABLE attribute is set to a null object.
When sampling is enabled on a port, the SAI_PORT_ATTR_INGRESS_SAMPLEPACKET_ENABLE attribute is set to a valid samplepacket object.
For sonic-vs, in the absence of a real ASIC programming, the 'tc' command is used instead to configure the sampling parameters inside the kernel. In this PR we invoke the appropriate 'tc' command, based on the requested config actions (disable or enable or update).
How to verify it
Description for the changelog
Additional Information
Please DO NOT MERGE until these PRs are merged:
Build infrastructure changes to support sflow docker and utilities sonic-buildimage#3251
Signed-off-by: Rakesh Datta rakesh.datta@dell.com