Generalizing config.bcm support for BRCM silicons #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
that's a lot of stuff added to config, does this needs to be executed every time ? and is this the right file to add this ? |
Yes, this is right place to add this which is only for BRCM and will be executed for every SONIC BOOT syncd docker init. Please check the HLD => sonic-net/SONiC#699 |
lguohan
reviewed
Nov 5, 2020
lguohan
reviewed
Nov 5, 2020
|
lguohan, I have added an option for this in new commit. By default the common config feature is disabled, and ODM can enable this feature by touch the common_config_support file in the $PLATFORM_DIR. Let me know if this works for you Geans |
geans-pin
changed the title
|
Commenter does not have sufficient privileges for PR 693 in repo Azure/sonic-sairedis |
1 similar comment
|
Commenter does not have sufficient privileges for PR 693 in repo Azure/sonic-sairedis |
|
/azpw run |
|
/Azurepipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Rebase and run checker again |
|
@gechiang to review this one as well. |
gechiang
approved these changes
May 26, 2021
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
* Per-switching silicon Common config for Broadcom Supported Platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.